ed/raddebugger
1
0
Fork 0
mirror of https://github.com/Ed94/raddebugger.git synced 2026-08-07 14:28:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix unchecked zero pointers in bake string map joining task, when zero pointers are legal

Browse Source
This commit is contained in:
Ryan Fleury
2024-03-15 14:16:30 -07:00
parent 22e6352056
commit 808d26684e
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/raddbgi_from_pdb/raddbgi_from_pdb.c
+4 -2
View File
@@ -3571,11 +3571,13 @@ internal TS_TASK_FUNCTION_DEF(p2r_bake_string_map_join_task__entry_point)
{ {
for(U64 slot_idx = in->slot_idx_range.min; slot_idx < in->slot_idx_range.max; slot_idx += 1) for(U64 slot_idx = in->slot_idx_range.min; slot_idx < in->slot_idx_range.max; slot_idx += 1)
{ {
if(in->dst_map->slots[slot_idx] == 0) B32 src_slots_good = (in->src_maps[src_map_idx] != 0 && in->src_maps[src_map_idx]->slots != 0);
B32 dst_slot_is_zero = (in->dst_map->slots[slot_idx] == 0);
if(src_slots_good && dst_slot_is_zero)
{ {
in->dst_map->slots[slot_idx] = in->src_maps[src_map_idx]->slots[slot_idx]; in->dst_map->slots[slot_idx] = in->src_maps[src_map_idx]->slots[slot_idx];
} }
else if(in->src_maps[src_map_idx]->slots[slot_idx] != 0) else if(src_slots_good && in->src_maps[src_map_idx]->slots[slot_idx] != 0)
{ {
rdim_bake_string_chunk_list_concat_in_place(in->dst_map->slots[slot_idx], in->src_maps[src_map_idx]->slots[slot_idx]); rdim_bake_string_chunk_list_concat_in_place(in->dst_map->slots[slot_idx], in->src_maps[src_map_idx]->slots[slot_idx]);
} }