eliminate assumptions of module presence in unwinding codepaths, & callstack UI; fixes callstacks for JIT'd code

This commit is contained in:
Ryan Fleury
2024-01-23 14:26:43 -08:00
parent 8bf8112edd
commit 804a8406b9
4 changed files with 84 additions and 98 deletions
-7
View File
@@ -3621,13 +3621,6 @@ df_push_unwind_from_thread(Arena *arena, DF_Entity *thread)
DBGI_Parse *dbgi = dbgi_parse_from_exe_path(scope, binary_full_path, 0);
String8 binary_data = str8((U8 *)dbgi->exe_base, dbgi->exe_props.size);
// rjf: cancel on bad data
if(binary_data.size == 0)
{
unwind.error = 1;
break;
}
// rjf: valid step -> push frame
DF_UnwindFrame *frame = push_array(arena, DF_UnwindFrame, 1);
frame->rip = rip;