adjust unwind loop to be robust to noop-unwind-steps that would otherwise result in infinite unwind loops

This commit is contained in:
Ryan Fleury
2024-06-17 12:14:10 -07:00
parent 6ad94978ce
commit 749821dd27
3 changed files with 8 additions and 8 deletions
+2 -1
View File
@@ -2624,7 +2624,8 @@ ctrl_unwind_from_thread(Arena *arena, CTRL_EntityStore *store, CTRL_MachineID ma
unwind.flags |= step.flags; unwind.flags |= step.flags;
if(step.flags & CTRL_UnwindFlag_Error || if(step.flags & CTRL_UnwindFlag_Error ||
regs_rsp_from_arch_block(arch, regs_block) == 0 || regs_rsp_from_arch_block(arch, regs_block) == 0 ||
regs_rip_from_arch_block(arch, regs_block) == 0) regs_rip_from_arch_block(arch, regs_block) == 0 ||
regs_rip_from_arch_block(arch, regs_block) == rip)
{ {
break; break;
} }
+5 -5
View File
@@ -265,10 +265,10 @@ DF_GfxViewRuleTable:
} }
//////////////////////////////// ////////////////////////////////
//~ rjf: Theme Color Codes //~ rjf: Theme Tables
@table(name display_name name_lower) @table(name display_name name_lower)
DF_ThemeTable: DF_ThemeColorTable:
{ {
{Null "Null" null } {Null "Null" null }
{PlainText "Plain Text" plain_text } {PlainText "Plain Text" plain_text }
@@ -424,7 +424,7 @@ DF_ThemePresetColorTable:
@enum DF_ThemeColor: @enum DF_ThemeColor:
{ {
@expand(DF_ThemeTable a) `$(a.name)`, @expand(DF_ThemeColorTable a) `$(a.name)`,
COUNT, COUNT,
} }
@@ -590,12 +590,12 @@ DF_ThemePresetColorTable:
@data(String8) df_g_theme_color_display_string_table: @data(String8) df_g_theme_color_display_string_table:
{ {
@expand(DF_ThemeTable a) `str8_lit_comp("$(a.display_name)")` @expand(DF_ThemeColorTable a) `str8_lit_comp("$(a.display_name)")`
} }
@data(String8) df_g_theme_color_cfg_string_table: @data(String8) df_g_theme_color_cfg_string_table:
{ {
@expand(DF_ThemeTable a) `str8_lit_comp("$(a.name_lower)")` @expand(DF_ThemeColorTable a) `str8_lit_comp("$(a.name_lower)")`
} }
//////////////////////////////// ////////////////////////////////
+1 -2
View File
@@ -42,8 +42,7 @@
//////////////////////////////// ////////////////////////////////
//~ rjf: Hot, High Priority Tasks (Complete Unusability, Crashes, Fire-Worthy) //~ rjf: Hot, High Priority Tasks (Complete Unusability, Crashes, Fire-Worthy)
// //
// [ ] investigate heavy outputdebugstring usage causing major issues // [ ] asan stepping breakage
// (both in debugger and in target application, apparently)
// [ ] "Browse..." buttons should adopt a more relevant starting search path, // [ ] "Browse..." buttons should adopt a more relevant starting search path,
// if possible // if possible
// [ ] PDB files distributed with the build are not found by DbgHelp!!! // [ ] PDB files distributed with the build are not found by DbgHelp!!!