ed/raddebugger
1
0
Fork 0
mirror of https://github.com/Ed94/raddebugger.git synced 2026-08-06 05:48:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

mark referenced symbols as live for unresolved-symbol detection

Browse Source
This commit is contained in:
Nikita Smith
2025-08-08 15:54:21 -07:00
parent 9893a8135d
commit 7466da1479
6 changed files with 113 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/linker/lnk.c
+13 -11
View File
@@ -1101,7 +1101,7 @@ lnk_find_refs(Arena *arena,
}
//
// walk relocations and mark referenced sections as live
// walk relocations and mark referenced sections with live flag
//
for (; task_stack; ) {
struct Task *t = task_stack; SLLStackPop(task_stack);
@@ -1115,12 +1115,10 @@ lnk_find_refs(Arena *arena,
for (;;) {
COFF_ParsedSymbol ref_parsed = lnk_parsed_symbol_from_coff_symbol_idx(ref_symbol.obj, ref_symbol.symbol_idx);
COFF_SymbolValueInterpType ref_interp = coff_interp_from_parsed_symbol(ref_parsed);
if (ref_interp == COFF_SymbolValueInterp_Weak) {
LNK_Symbol *defn = lnk_symbol_table_search(symtab, LNK_SymbolScope_Defined, ref_parsed.name);
COFF_ParsedSymbol defn_parsed = lnk_parsed_symbol_from_defined(defn);
COFF_SymbolValueInterpType defn_interp = coff_interp_from_parsed_symbol(defn_parsed);
if (defn_interp == COFF_SymbolValueInterp_Weak) {
LNK_Symbol *member_symbol = 0;
COFF_SymbolWeakExt *weak_ext = coff_parse_weak_tag(ref_parsed, ref_symbol.obj->header.is_big_obj);
@@ -1172,12 +1170,11 @@ lnk_find_refs(Arena *arena,
}
}
else if (ref_interp == COFF_SymbolValueInterp_Undefined) {
MemoryZeroStruct(&ref_symbol);
if (ref_parsed.storage_class == COFF_SymStorageClass_External) {
LNK_Symbol *defn = lnk_symbol_table_search(symtab, LNK_SymbolScope_Defined, ref_parsed.name);
COFF_ParsedSymbol defn_parsed = lnk_parsed_symbol_from_defined(defn);
COFF_SymbolValueInterpType defn_interp = coff_interp_from_parsed_symbol(defn_parsed);
if (defn_interp == COFF_SymbolValueInterp_Undefined) {
LNK_Symbol *member_symbol = lnk_symbol_table_search(symtab, LNK_SymbolScope_Lib, ref_parsed.name);
if (member_symbol) {
@@ -1208,6 +1205,13 @@ lnk_find_refs(Arena *arena,
COFF_SymbolValueInterpType ref_interp = coff_interp_from_parsed_symbol(ref_parsed);
LNK_Obj *ref_obj = ref_symbol.obj;
// mark referenced symbol live
if (ref_parsed.storage_class == COFF_SymStorageClass_External ||
ref_parsed.storage_class == COFF_SymStorageClass_WeakExternal) {
LNK_Symbol *ref_symbol = lnk_symbol_table_search(symtab, LNK_SymbolScope_Defined, ref_parsed.name);
lnk_mark_symbol_live(ref_symbol);
}
if (ref_interp == COFF_SymbolValueInterp_Regular) {
// make section number list (reloc section + associates)
U32Node *section_number_list = push_array(scratch.arena, U32Node, 1);
@@ -2122,9 +2126,8 @@ lnk_build_link_context(TP_Context *tp, TP_Arena *tp_arena, LNK_Config *config)
for EachIndex(i, chunk->count) {
LNK_Symbol *symbol = chunk->v[i].symbol;
if (symbol->is_live) {
COFF_ParsedSymbol symbol_parsed = lnk_parsed_symbol_from_defined(symbol);
COFF_SymbolValueInterpType symbol_interp = coff_interp_from_parsed_symbol(symbol_parsed);
if (symbol_interp == COFF_SymbolValueInterp_Undefined) {
COFF_ParsedSymbol symbol_parsed = lnk_parsed_symbol_from_defined(symbol);
if (coff_is_undefined_data_symbol(symbol_parsed)) {
undefs_count += 1;
}
}
@@ -2138,9 +2141,8 @@ lnk_build_link_context(TP_Context *tp, TP_Arena *tp_arena, LNK_Config *config)
for EachIndex(i, chunk->count) {
LNK_Symbol *symbol = chunk->v[i].symbol;
if (symbol->is_live) {
COFF_ParsedSymbol symbol_parsed = lnk_parsed_symbol_from_defined(symbol);
COFF_SymbolValueInterpType symbol_interp = coff_interp_from_parsed_symbol(symbol_parsed);
if (symbol_interp == COFF_SymbolValueInterp_Undefined) {
COFF_ParsedSymbol symbol_parsed = lnk_parsed_symbol_from_defined(symbol);
if (coff_is_undefined_data_symbol(symbol_parsed)) {
undefs[undefs_cursor++] = chunk->v[i].symbol;
}
}
src/linker/lnk.h
+3 -3
View File
@@ -5,6 +5,9 @@
// --- Link --------------------------------------------------------------------
#define LNK_IMPORT_STUB "*** RAD_IMPORT_STUB ***"
#define LNK_SECTION_FLAG_IS_LIVE (1 << 0)
typedef struct LNK_LinkContext
{
LNK_SymbolTable *symtab;
@@ -15,12 +18,9 @@ typedef struct LNK_LinkContext
// -- Image --------------------------------------------------------------------
#define LNK_IMPORT_STUB "*** RAD_IMPORT_STUB ***"
#define LNK_REMOVED_SECTION_NUMBER_32 (U32)-3
#define LNK_REMOVED_SECTION_NUMBER_16 (U16)-3
#define LNK_SECTION_FLAG_IS_LIVE (1 << 0)
typedef struct LNK_ImageContext
{
String8 image_data;
src/linker/lnk_obj.c
+6 -8
View File
@@ -345,11 +345,9 @@ THREAD_POOL_TASK_FUNC(lnk_input_coff_symbol_table)
{
LNK_InputCoffSymbolTable *task = raw_task;
LNK_Obj *obj = &task->objs.v[task_id].data;
COFF_ParsedSymbol symbol = {0};
for (U64 symbol_idx = 0; symbol_idx < obj->header.symbol_count; symbol_idx += (1 + symbol.aux_symbol_count)) {
symbol = lnk_parsed_symbol_from_coff_symbol_idx(obj, symbol_idx);
COFF_SymbolValueInterpType interp = coff_interp_from_parsed_symbol(symbol);
switch (interp) {
case COFF_SymbolValueInterp_Regular: {
@@ -366,17 +364,17 @@ THREAD_POOL_TASK_FUNC(lnk_input_coff_symbol_table)
LNK_Symbol *defn = lnk_make_defined_symbol(arena, symbol.name, obj, symbol_idx);
lnk_symbol_table_push_(task->symtab, arena, worker_id, LNK_SymbolScope_Defined, defn);
} break;
case COFF_SymbolValueInterp_Common: {
LNK_Symbol *defn = lnk_make_defined_symbol(arena, symbol.name, obj, symbol_idx);
lnk_symbol_table_push_(task->symtab, arena, worker_id, LNK_SymbolScope_Defined, defn);
} break;
case COFF_SymbolValueInterp_Abs: {
case COFF_SymbolValueInterp_Undefined: {
if (symbol.storage_class == COFF_SymStorageClass_External) {
LNK_Symbol *defn = lnk_make_defined_symbol(arena, symbol.name, obj, symbol_idx);
lnk_symbol_table_push_(task->symtab, arena, worker_id, LNK_SymbolScope_Defined, defn);
}
} break;
case COFF_SymbolValueInterp_Undefined: {
case COFF_SymbolValueInterp_Common: {
LNK_Symbol *defn = lnk_make_defined_symbol(arena, symbol.name, obj, symbol_idx);
lnk_symbol_table_push_(task->symtab, arena, worker_id, LNK_SymbolScope_Defined, defn);
} break;
case COFF_SymbolValueInterp_Abs: {
if (symbol.storage_class == COFF_SymStorageClass_External) {
LNK_Symbol *defn = lnk_make_defined_symbol(arena, symbol.name, obj, symbol_idx);
lnk_symbol_table_push_(task->symtab, arena, worker_id, LNK_SymbolScope_Defined, defn);