From 6a44f6485d4bc733b67016d8ce70e1aa25566c0d Mon Sep 17 00:00:00 2001 From: Ryan Fleury Date: Tue, 18 Mar 2025 16:30:14 -0700 Subject: [PATCH] eliminate old and now unused parts of hover eval state --- src/raddbg/raddbg_core.c | 14 +------------- src/raddbg/raddbg_core.h | 9 --------- 2 files changed, 1 insertion(+), 22 deletions(-) diff --git a/src/raddbg/raddbg_core.c b/src/raddbg/raddbg_core.c index 1ee9adf8..94adf190 100644 --- a/src/raddbg/raddbg_core.c +++ b/src/raddbg/raddbg_core.c @@ -8435,19 +8435,10 @@ rd_window_frame(void) EV_ExpandRuleTagPair expand_rule_tag = ev_expand_rule_tag_pair_from_expr_irtree(hover_eval.exprs.last, &hover_eval.irtree); RD_ViewUIRule *view_ui_rule = rd_view_ui_rule_from_string(expand_rule_tag.rule->string); - // rjf: reset open animation - if(ws->hover_eval_string.size == 0) - { - ws->hover_eval_open_t = 0; - ws->hover_eval_num_visible_rows_t = 0; - } - - // rjf: reset animation, but request frames if we're waiting to open + // rjf: request frames if we're waiting to open if(ws->hover_eval_string.size != 0 && !hover_eval_is_open && ws->hover_eval_last_frame_idx < ws->hover_eval_first_frame_idx+20 && rd_state->frame_index-ws->hover_eval_last_frame_idx < 50) { rd_request_frame(); - ws->hover_eval_num_visible_rows_t = 0; - ws->hover_eval_open_t = 0; } // rjf: reset focus state if hover eval is not being built @@ -10849,9 +10840,6 @@ rd_set_hover_eval(Vec2F32 pos, String8 file_path, TxtPt pt, U64 vaddr, String8 s arena_clear(ws->hover_eval_arena); ws->hover_eval_string = push_str8_copy(ws->hover_eval_arena, string); ws->hover_eval_view_rules = push_str8_copy(ws->hover_eval_arena, view_rules); - ws->hover_eval_file_path = push_str8_copy(ws->hover_eval_arena, file_path); - ws->hover_eval_file_pt = pt; - ws->hover_eval_vaddr = vaddr; ws->hover_eval_focused = 0; } ws->hover_eval_spawn_pos = pos; diff --git a/src/raddbg/raddbg_core.h b/src/raddbg/raddbg_core.h index 3a028c2d..ee277276 100644 --- a/src/raddbg/raddbg_core.h +++ b/src/raddbg/raddbg_core.h @@ -589,21 +589,12 @@ struct RD_WindowState // rjf: hover eval state B32 hover_eval_focused; - TxtPt hover_eval_txt_cursor; - TxtPt hover_eval_txt_mark; - U8 hover_eval_txt_buffer[1024]; - U64 hover_eval_txt_size; Arena *hover_eval_arena; Vec2F32 hover_eval_spawn_pos; String8 hover_eval_string; String8 hover_eval_view_rules; U64 hover_eval_first_frame_idx; U64 hover_eval_last_frame_idx; - String8 hover_eval_file_path; - TxtPt hover_eval_file_pt; - U64 hover_eval_vaddr; - F32 hover_eval_open_t; - F32 hover_eval_num_visible_rows_t; // rjf: error state U8 error_buffer[512];