From 5a79518dcb48f3bbc8a8bca73dd0f794e4e991ed Mon Sep 17 00:00:00 2001
From: Ryan Fleury <ryan.j.fleury@gmail.com>
Date: Wed, 13 Nov 2024 16:05:22 -0800
Subject: [PATCH] fix debug directory tree cache clearing rule

---
 src/ctrl/ctrl_core.c | 29 +++++++++++++----------------
 1 file changed, 13 insertions(+), 16 deletions(-)

diff --git a/src/ctrl/ctrl_core.c b/src/ctrl/ctrl_core.c
index 9b85aeb9..b75ef35b 100644
--- a/src/ctrl/ctrl_core.c
+++ b/src/ctrl/ctrl_core.c
@@ -4112,12 +4112,19 @@ ctrl_thread__next_dmn_event(Arena *arena, DMN_CtrlCtx *ctrl_ctx, CTRL_Msg *msg,
   }
   ctrl_c2u_push_events(&evts);
   
-  //- rjf: when a new process is loaded, for the first module, pre-emptively
-  // try to open all adjacent debug infos. with debug events, we learn about
-  // loaded modules serially, and we need to completely load debug info before
-  // continuing. for massive projects, this is a problem, because completely
-  // loading debug info isn't a trivial cost, and there are often 1000s of
-  // DLLs.
+  //- rjf: if this is the first process in a session, clear the debug directory
+  // cache state
+  if(ctrl_state->process_counter == 1 && event->kind == DMN_EventKind_CreateProcess)
+  {
+    arena_clear(ctrl_state->dbg_dir_arena);
+    ctrl_state->dbg_dir_root = push_array(ctrl_state->dbg_dir_arena, CTRL_DbgDirNode, 1);
+  }
+  
+  //- rjf: when a new module is loaded, pre-emptively try to open all adjacent
+  // debug infos. with debug events, we learn about loaded modules serially,
+  // and we need to completely load debug info before continuing. for massive
+  // projects, this is a problem, because completely loading debug info isn't a
+  // trivial cost, and there are often 1000s of DLLs.
   //
   // an imperfect but usually reasonable heuristic is to look at adjacent
   // debug info files, in the same or under the directory as the initially
@@ -4132,16 +4139,6 @@ ctrl_thread__next_dmn_event(Arena *arena, DMN_CtrlCtx *ctrl_ctx, CTRL_Msg *msg,
     CTRL_Entity *process = ctrl_entity_from_handle(ctrl_state->ctrl_thread_entity_store, process_handle);
     CTRL_Entity *loaded_module = ctrl_entity_from_handle(ctrl_state->ctrl_thread_entity_store, loaded_module_handle);
     
-    //- rjf: determine if this is the first process launched in this session
-    B32 is_first_process = (ctrl_state->process_counter == 1);
-    
-    //- rjf: if this is the first process this session, clear the debug directory state
-    if(is_first_process)
-    {
-      arena_clear(ctrl_state->dbg_dir_arena);
-      ctrl_state->dbg_dir_root = push_array(ctrl_state->dbg_dir_arena, CTRL_DbgDirNode, 1);
-    }
-    
     //- rjf: for each module, use its full path as the start to a new limited recursive
     // directory search. cache each directory once traversed in the dbg_dir tree. if any
     // node is not cached, then scan it & pre-emptively convert debug info.