ed/raddebugger
1
0
Fork 0
mirror of https://github.com/Ed94/raddebugger.git synced 2026-08-06 05:48:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

adjust good-machine-code check to factor in memory read failure mask

Browse Source
This commit is contained in:
Ryan Fleury
2025-05-22 17:15:51 -07:00
parent 914273d5af
commit 58df68b9be
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/dbg_engine/dbg_engine_core.c
+4 -2
View File
@@ -378,10 +378,12 @@ d_trap_net_from_thread__step_over_line(Arena *arena, CTRL_Entity *thread)
// rjf: line vaddr range => line's machine code // rjf: line vaddr range => line's machine code
String8 machine_code = {0}; String8 machine_code = {0};
B32 good_machine_code = 0;
if(good_line_info) if(good_line_info)
{ {
CTRL_ProcessMemorySlice machine_code_slice = ctrl_process_memory_slice_from_vaddr_range(scratch.arena, process->handle, line_vaddr_rng, os_now_microseconds()+50000); CTRL_ProcessMemorySlice machine_code_slice = ctrl_process_memory_slice_from_vaddr_range(scratch.arena, process->handle, line_vaddr_rng, os_now_microseconds()+50000);
machine_code = machine_code_slice.data; machine_code = machine_code_slice.data;
good_machine_code = (machine_code.size == dim_1u64(line_vaddr_rng) && !machine_code_slice.any_byte_bad);
LogInfoNamedBlockF("machine_code_slice") LogInfoNamedBlockF("machine_code_slice")
{ {
log_infof("stale: %i\n", machine_code_slice.stale); log_infof("stale: %i\n", machine_code_slice.stale);
@@ -399,7 +401,6 @@ d_trap_net_from_thread__step_over_line(Arena *arena, CTRL_Entity *thread)
log_infof("]\n"); log_infof("]\n");
} }
} }
B32 good_machine_code = (good_line_info && machine_code.size == dim_1u64(line_vaddr_rng));
// rjf: machine code => ctrl flow analysis // rjf: machine code => ctrl flow analysis
DASM_CtrlFlowInfo ctrl_flow_info = {0}; DASM_CtrlFlowInfo ctrl_flow_info = {0};
@@ -535,12 +536,13 @@ d_trap_net_from_thread__step_into_line(Arena *arena, CTRL_Entity *thread)
// rjf: line vaddr range => line's machine code // rjf: line vaddr range => line's machine code
String8 machine_code = {0}; String8 machine_code = {0};
B32 good_machine_code = 0;
if(good_line_info) if(good_line_info)
{ {
CTRL_ProcessMemorySlice machine_code_slice = ctrl_process_memory_slice_from_vaddr_range(scratch.arena, process->handle, line_vaddr_rng, os_now_microseconds()+5000); CTRL_ProcessMemorySlice machine_code_slice = ctrl_process_memory_slice_from_vaddr_range(scratch.arena, process->handle, line_vaddr_rng, os_now_microseconds()+5000);
machine_code = machine_code_slice.data; machine_code = machine_code_slice.data;
good_machine_code = (machine_code.size == dim_1u64(line_vaddr_rng) && !machine_code_slice.any_byte_bad);
} }
B32 good_machine_code = (good_line_info && machine_code.size == dim_1u64(line_vaddr_rng));
// rjf: machine code => ctrl flow analysis // rjf: machine code => ctrl flow analysis
DASM_CtrlFlowInfo ctrl_flow_info = {0}; DASM_CtrlFlowInfo ctrl_flow_info = {0};