ed/raddebugger
1
0
Fork 0
mirror of https://github.com/Ed94/raddebugger.git synced 2026-08-06 05:48:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

always allocate byte dirty/unreadable flags in ctrl process memory cache lookup, rather than trusting caller to check

Browse Source
This commit is contained in:
Ryan Fleury
2024-01-29 11:56:34 -08:00
parent 3fd9014c20
commit 57fb21adf7
2 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ctrl/ctrl_core.c
+4 -2
View File
@@ -902,6 +902,8 @@ internal CTRL_ProcessMemorySlice
ctrl_query_cached_data_from_process_vaddr_range(Arena *arena, CTRL_MachineID machine_id, CTRL_Handle process, Rng1U64 range) ctrl_query_cached_data_from_process_vaddr_range(Arena *arena, CTRL_MachineID machine_id, CTRL_Handle process, Rng1U64 range)
{ {
CTRL_ProcessMemorySlice result = {0}; CTRL_ProcessMemorySlice result = {0};
result.byte_bad_flags = push_array(arena, U64, (dim_1u64(range)+63)/64);
result.byte_changed_flags = push_array(arena, U64, (dim_1u64(range)+63)/64);
if(range.max > range.min && if(range.max > range.min &&
dim_1u64(range) <= MB(256) && dim_1u64(range) <= MB(256) &&
range.min <= 0x000FFFFFFFFFFFFFull && range.min <= 0x000FFFFFFFFFFFFFull &&
@@ -931,8 +933,8 @@ ctrl_query_cached_data_from_process_vaddr_range(Arena *arena, CTRL_MachineID mac
//- rjf: setup output buffers //- rjf: setup output buffers
void *read_out = push_array(arena, U8, dim_1u64(range)); void *read_out = push_array(arena, U8, dim_1u64(range));
U64 *byte_bad_flags = push_array(arena, U64, (dim_1u64(range)+63)/64); U64 *byte_bad_flags = result.byte_bad_flags;
U64 *byte_changed_flags = push_array(arena, U64, (dim_1u64(range)+63)/64); U64 *byte_changed_flags = result.byte_changed_flags;
//- rjf: iterate pages, fill output //- rjf: iterate pages, fill output
{ {
src/df/gfx/df_views.c
+4 -7
View File
@@ -987,15 +987,12 @@ df_eval_watch_view_build(DF_Window *ws, DF_Panel *panel, DF_View *view, DF_EvalW
size = Min(size, 64); size = Min(size, 64);
Rng1U64 vaddr_rng = r1u64(row->eval.offset, row->eval.offset+size); Rng1U64 vaddr_rng = r1u64(row->eval.offset, row->eval.offset+size);
CTRL_ProcessMemorySlice slice = ctrl_query_cached_data_from_process_vaddr_range(scratch.arena, process->ctrl_machine_id, process->ctrl_handle, vaddr_rng); CTRL_ProcessMemorySlice slice = ctrl_query_cached_data_from_process_vaddr_range(scratch.arena, process->ctrl_machine_id, process->ctrl_handle, vaddr_rng);
if(slice.byte_changed_flags != 0) for(U64 idx = 0; idx < (size+63)/64; idx += 1)
{ {
for(U64 idx = 0; idx < (size+63)/64; idx += 1) if(slice.byte_changed_flags[idx] != 0)
{ {
if(slice.byte_changed_flags[idx] != 0) row_is_fresh = 1;
{ break;
row_is_fresh = 1;
break;
}
} }
} }
}break; }break;