eliminate eval-viewer view - instead we can have the gfx view rule spec table optionally define tab view specs itself, and those can be separately registered from the sort of 'base' tab views. then we can map from gfx-view-rule -> dedicated-tab-view-spec

This commit is contained in:
Ryan Fleury
2024-04-02 10:16:53 -07:00
parent 3ea67dd7cf
commit 546c544ae0
8 changed files with 78 additions and 66 deletions
+1 -11
View File
@@ -1075,7 +1075,7 @@ df_eval_watch_view_build(DF_Window *ws, DF_Panel *panel, DF_View *view, DF_EvalW
{
DF_CmdParams p = df_cmd_params_from_view(ws, panel, view);
p.string = row->edit_expr;
p.view_spec = df_view_spec_from_gfx_view_kind(DF_GfxViewKind_EvalViewer);
p.view_spec = df_tab_view_spec_from_gfx_view_rule_spec(row->expand_ui_rule_spec);
df_cmd_params_mark_slot(&p, DF_CmdParamSlot_String);
df_cmd_params_mark_slot(&p, DF_CmdParamSlot_ViewSpec);
df_push_cmd__root(&p, df_cmd_spec_from_core_cmd_kind(DF_CoreCmdKind_OpenTab));
@@ -6837,16 +6837,6 @@ DF_VIEW_UI_FUNCTION_DEF(Disassembly)
ProfEnd();
}
////////////////////////////////
//~ rjf: EvalViewer @view_hook_impl
DF_VIEW_SETUP_FUNCTION_DEF(EvalViewer) {}
DF_VIEW_STRING_FROM_STATE_FUNCTION_DEF(EvalViewer) { return str8_lit(""); }
DF_VIEW_CMD_FUNCTION_DEF(EvalViewer) {}
DF_VIEW_UI_FUNCTION_DEF(EvalViewer)
{
}
////////////////////////////////
//~ rjf: Watch @view_hook_impl