From 4eae2a2ecca3eead3c091808b5005ad640faa192 Mon Sep 17 00:00:00 2001 From: Nikita Smith Date: Tue, 18 Aug 2026 15:29:42 -0700 Subject: [PATCH] clang fixes --- src/linker/lnk.c | 3 ++- src/linker/lnk_config.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/linker/lnk.c b/src/linker/lnk.c index 1cf6a84d..e29f7947 100644 --- a/src/linker/lnk.c +++ b/src/linker/lnk.c @@ -2279,7 +2279,7 @@ lnk_link_image(TP_Context *tp, TP_Arena *arena, LNK_Config *config, LNK_Inputer String8List list = {0}; for EachIndex(i, entry_points.count) { str8_list_push(scratch.arena, &list, entry_points.v[i]); } - String8 default_entries = str8_list_join(scratch.arena, &list, &(StringJoin){.sep = ", "}); + String8 default_entries = str8_list_join(scratch.arena, &list, &(StringJoin){.sep = str8_lit(", ")}); lnk_error(LNK_Error_EntryPoint, "failed to infer entry point symbol from the inputs\n" @@ -3615,6 +3615,7 @@ THREAD_POOL_TASK_FUNC(lnk_opt_icf_task) #define X(ID) case LNK_ICF_Scope_##ID: scope_str = str8_lit(Stringify(ID)); break; LNK_ICF_Scope_XList #undef X + default: InvalidPath; } lnk_log(LNK_Log_Debug, " %-9S: removed %M, %.*s sections; live %M, %.*s sections", diff --git a/src/linker/lnk_config.c b/src/linker/lnk_config.c index 6c28deeb..2e78384f 100644 --- a/src/linker/lnk_config.c +++ b/src/linker/lnk_config.c @@ -2900,7 +2900,7 @@ lnk_config_init(U64 argc, char **argv) { LNK_EnvVar *link; - if (link = lnk_env_var_from_mapf(&env_vars, "LINK")) { + if ((link = lnk_env_var_from_mapf(&env_vars, "LINK"))) { String8List args = lnk_arg_list_parse_windows_rules(scratch.arena, link->raw_value); str8_list_concat_in_place(&user_args, &args); } @@ -2909,7 +2909,7 @@ lnk_config_init(U64 argc, char **argv) str8_list_push(scratch.arena, &user_args, str8_cstring(argv[i])); } - if (link = lnk_env_var_from_mapf(&env_vars, "_LINK_")) { + if ((link = lnk_env_var_from_mapf(&env_vars, "_LINK_"))) { String8List args = lnk_arg_list_parse_windows_rules(scratch.arena, link->raw_value); str8_list_concat_in_place(&user_args, &args); }