first pass at (rdi -> loose rdim) path, used in (rdi * ... * rdi) -> rdi joining in radbin; plug in regular conversion path before voff -> line & breakpad paths in radbin, such that PDBs, DWARFs, RDIs, etc. can be used as input; fix up voff -> line path to plug into regular output systems; remove String8 union thing - three reasons: (a) it was only ever introduced for convenience in Linux layers, so let's just keep zero-terminated Linux nonsense in Linux land, (b) it was just alternate syntax for a cast, so let's just cast, (c) it was misleading - 'cstr' implies null-termination, which String8 of course doesn't guarantee. this led to some misuses, where .cstr was trusted to be zero-terminated, when that was not necessarily true (semaphore opening).

src/msf/msf_parse.c

@@ -9,7 +9,7 @@ msf_raw_stream_table_from_data(Arena *arena, String8 msf_data)
 {
   Temp scratch = scratch_begin(&arena, 1);
   
-  MSF_RawStreamTable *result = 0;
+  MSF_RawStreamTable *result = push_array(arena, MSF_RawStreamTable, 1);
   
   //- determine msf type
   U32 index_size = 0;
@@ -214,7 +214,6 @@ msf_raw_stream_table_from_data(Arena *arena, String8 msf_data)
     }
     
     if (got_streams) {
-      result                   = push_array(arena, MSF_RawStreamTable, 1);
       result->total_page_count = whole_file_page_count;
       result->index_size       = index_size;
       result->page_size        = page_size;