move lib member queue state to the link step and release it after link step is done

This commit is contained in:
Nikita Smith committed 2026-01-20 15:27:31 -08:00
1 parent d1b055c62f
commit 1c0e9030fa
5 files changed
+107 -77

No files matched your search

-39
View File
@@ -141,8 +141,6 @@ lnk_lib_from_data(Arena *arena, String8 data, String8 path, U64 input_idx, LNK_L
lib_out->symbol_count = Min(symbol_count, symbol_names.count); // TODO: warn about mismatched number of symbol names and symbol count in the header
lib_out->member_offsets = member_offsets;
lib_out->symbol_indices = symbol_indices;
lib_out->member_links = push_array(arena, LNK_Symbol *, member_count);
lib_out->member_flags = push_array(arena, LNK_LibMemberFlags, member_count);
lib_out->symbol_names = symbol_names;
lib_out->long_names = parse.long_names;
lib_out->input_idx = input_idx;
@@ -222,43 +220,6 @@ lnk_lib_list_push_parallel(TP_Context *tp, TP_Arena *arena, LNK_LibList *list, U
return result;
}
internal B32
lnk_lib_set_link_symbol(LNK_Lib *lib, U32 member_idx, LNK_Symbol *link_symbol)
{
B32 was_linked;
if (str8_starts_with(link_symbol->name, str8_lit("__imp_"))) {
U8 member_flags = ins_atomic_u8_or(&lib->member_flags[member_idx], LNK_LibMemberFlag_LinkedImp);
was_linked = !!(~member_flags & LNK_LibMemberFlag_LinkedImp);
} else {
U8 flag = LNK_LibMemberFlag_LinkedRegular;
U8 member_flags = ins_atomic_u8_or(&lib->member_flags[member_idx], LNK_LibMemberFlag_LinkedRegular);
was_linked = !!(~member_flags & LNK_LibMemberFlag_LinkedRegular);
}
for (LNK_Symbol *leader = link_symbol;;) {
LNK_Symbol *slot = ins_atomic_ptr_eval_assign(&lib->member_links[member_idx], 0);
// update slot symbol if it is empty or link symbol comes before symbol in the slot
if (slot) {
if (lnk_symbol_is_before(slot, leader)) {
leader = slot;
}
} else {
leader = link_symbol;
}
// try to insert back updated slot symbol
LNK_Symbol *swap = ins_atomic_ptr_eval_cond_assign(&lib->member_links[member_idx], leader, 0);
// exit if slot symbol was null
if (swap == 0) {
break;
}
}
return was_linked;
}
internal force_inline B32
lnk_search_lib(LNK_Lib *lib, String8 symbol_name, U32 *member_idx_out)
{