From 00594a841a3259bfba1dcd6d30d23a9119571cba Mon Sep 17 00:00:00 2001 From: Ryan Fleury Date: Tue, 30 Jan 2024 14:44:11 -0800 Subject: [PATCH] notes --- src/df/gfx/df_views.c | 4 ++++ src/raddbg/raddbg.h | 21 --------------------- 2 files changed, 4 insertions(+), 21 deletions(-) diff --git a/src/df/gfx/df_views.c b/src/df/gfx/df_views.c index cb94e2c9..80e26675 100644 --- a/src/df/gfx/df_views.c +++ b/src/df/gfx/df_views.c @@ -4142,6 +4142,10 @@ DF_VIEW_UI_FUNCTION_DEF(CallStack) symbol = str8_lit("[external code]"); ui_set_next_text_color(df_rgba_from_theme_color(DF_ThemeColor_WeakText)); } + else + { + ui_set_next_text_color(df_rgba_from_theme_color(DF_ThemeColor_CodeFunction)); + } UI_Box *box = ui_build_box_from_string(UI_BoxFlag_DrawText|UI_BoxFlag_Clickable, symbol); UI_Signal sig = ui_signal_from_box(box); if(sig.pressed) diff --git a/src/raddbg/raddbg.h b/src/raddbg/raddbg.h index e3d3bc6e..11bcab99 100644 --- a/src/raddbg/raddbg.h +++ b/src/raddbg/raddbg.h @@ -76,8 +76,6 @@ // [ ] investigate /DEBUG:FASTLINK - can we somehow alert that we do not // support it? // -// [x] escaping in config files - breakpoint labels etc. -// // [ ] visualize conversion failures // // [ ] I was a little confused about what a profile file was. I understood @@ -88,16 +86,6 @@ // to say that I was confused about it after reading the manual, so // perhaps you could elaborate a little more on it in there. // -// [ ] ** "Find Name" may not be working as advertised. In the description, it -// says you can jump to a file, but if I type in the complete filename of -// a file in the project and hit return, it just turns red and says it -// couldn't find it. This happens even if the file is already open in a -// tab. -// [ ] "Find Name" would be a lot more useful if you could type partial -// things, and it displayed a list, more like what happens in a -// traditional text editor. Typing the entire name of a function to jump -// to it is too laborious. -// // [ ] Right-clicking on a thread in the Scheduler window pops up a context // menu, but you can't actually see it because the tooltip for the thread // draws on top of it, so you can't see the menu. @@ -139,10 +127,6 @@ // have alternating bright/dim letters to show sections of a number. Is // this in the theme colors somewhere? // -// [ ] For breakpoint-on-function, it would be great if it showed a list of -// (partial) matches as you type, so you can stop typing once it gets the -// right function instead of having to type the entire function name. -// // [ ] ** I couldn't figure out how to really view threads in the debugger. // The only place I found a thread list was in "The Scheduler", but it // only lists threads by ID, which is hard to use. I can hover over them @@ -197,11 +181,6 @@ // opens the context window. It seems like maybe menus should be right, // and left should do the default action, more consistently? // -// [x] Hovering over disassembly highlights blocks of instructions, which I -// assume correspond to source lines. But perhaps it should also highlight -// the source lines? The inverse hover works (you hover over source, and -// it highlights ASM), but ASM->source doesn't. -// // [ ] It wasn't clear to me how you save a user or profile file. I can see // how to load them, but not how you save them. Obviously I can just copy // the files myself in the shell, but it seemed weird that there was no