From e8a4ede534722be38264a3f179261885f0be2046 Mon Sep 17 00:00:00 2001 From: Ed_ Date: Thu, 18 Jun 2026 19:32:52 -0400 Subject: [PATCH] conductor(plan): Mark Task 1.3 complete (regression fix for _offload_entry_payload) Task 1.3: src/app_controller.py _offload_entry_payload now unwraps the Result returned by session_logger.log_tool_call. The half-migrated function returned Result[data=str | None] but the call site did Path(ref_path).name, raising TypeError on every tool_call event. Refs: 26e57577 --- .../tracks/result_migration_app_controller_20260618/plan.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/conductor/tracks/result_migration_app_controller_20260618/plan.md b/conductor/tracks/result_migration_app_controller_20260618/plan.md index 245beeb5..a5c556d4 100644 --- a/conductor/tracks/result_migration_app_controller_20260618/plan.md +++ b/conductor/tracks/result_migration_app_controller_20260618/plan.md @@ -28,6 +28,8 @@ Focus: register the sub-track, then immediately fix the 2 known regressions (tes - **COMMIT:** `conductor: register result_migration_app_controller_20260618 in tracks.md` - **GIT NOTE:** 1-sentence note +- [x] **Task 1.3: Fix `_offload_entry_payload` call site (Regression 1)** [26e57577] + ### Task 1.3: Fix `_offload_entry_payload` call site (Regression 1) - **WHERE:** `src/app_controller.py:3709-3725` (`_offload_entry_payload` method) - **WHAT:** Unwrap the `Result` returned by `session_logger.log_tool_output` and `session_logger.log_tool_call`. The current code does `Path(ref_path).name` where `ref_path` is a `Result` object — `Path()` expects a string.