From e80d2952bcf8e1f5bc7f7fd2730835a5af6a50f2 Mon Sep 17 00:00:00 2001 From: Ed_ Date: Thu, 2 Jul 2026 19:05:43 -0400 Subject: [PATCH] docs(harness+conductor): cover 5 missing styleguides in harvest; cosmetic cleanups MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit directive_hotswap_harness_20260627/spec.md: added the 5 missing conductor/code_styleguides/*.md files to the harvest source list (config_state_owner, workspace_paths, test_sandbox, chroma_cache, code_path_audit) — the original list named 9 of 14. Added note that the harvester should verify each contains a harvestable directive before creating v1.md. Also verified tier2-autonomous.md path exists (17,940 bytes) for plan Step 2.7. tech-stack.md: removed duplicate src/paths.py entry (the full description at line 37 already covers it; the line-73 stub was redundant). edit_workflow.md: Key Files section now points to src/project_files.py for FileItem (moved out of src/models.py per the module taxonomy refactor) and notes the line ~2748 ref may drift. --- conductor/edit_workflow.md | 4 ++-- conductor/tech-stack.md | 1 - .../tracks/directive_hotswap_harness_20260627/spec.md | 11 +++++++++-- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/conductor/edit_workflow.md b/conductor/edit_workflow.md index e19b7b44..24e5667a 100644 --- a/conductor/edit_workflow.md +++ b/conductor/edit_workflow.md @@ -199,8 +199,8 @@ Files & Media works. Context Composition needs: ## Key Files - `src/gui_2.py` - Main GUI (1-space indentation, CRLF) -- `src/models.py` - Data models including FileItem -- Context Composition function: line ~2748 +- `src/project_files.py` - `FileItem` dataclass (moved out of `src/models.py` per `module_taxonomy_refactor_20260627`); `src/models.py` is now a ~1.5KB re-export shim +- Context Composition function: line ~2748 (verify with `py_get_code_outline` before editing — line refs drift) ## Test Command diff --git a/conductor/tech-stack.md b/conductor/tech-stack.md index 8f577850..4f555bb6 100644 --- a/conductor/tech-stack.md +++ b/conductor/tech-stack.md @@ -70,7 +70,6 @@ - **src/workspace_manager.py:** Implements the `WorkspaceManager` and `WorkspaceProfile` data models for saving, loading, and merging ImGui docking layouts and window states across global and project-specific configurations. -- **src/paths.py:** Centralized module for path resolution. - **tree-sitter / AST Parsing:** For deterministic AST parsing and automated generation of curated "Skeleton Views" and "Targeted Views" (extracting specific functions and their dependencies). Supports Python, C, and C++. Features an integrated AST cache with mtime-based invalidation to minimize re-parsing overhead. Supplemented by `SummaryCache` which provides persistent, hash-based (SHA256) caching with LRU eviction for AI-generated file summaries. - **pydantic / dataclasses:** For defining strict state schemas (Tracks, Tickets) used in linear orchestration. - **tomli-w:** For writing TOML configuration files. diff --git a/conductor/tracks/directive_hotswap_harness_20260627/spec.md b/conductor/tracks/directive_hotswap_harness_20260627/spec.md index 6472d796..fcd2e0c9 100644 --- a/conductor/tracks/directive_hotswap_harness_20260627/spec.md +++ b/conductor/tracks/directive_hotswap_harness_20260627/spec.md @@ -131,7 +131,7 @@ The directives are NOT limited to the 11 files the role prompts mandate. They're - Architecture documentation ("Thread domains are separated by...") - Reference material ("The 45-tool inventory includes...") -**Sources to comb (non-exhaustive):** +**Sources to comb (non-exhaustive; updated 2026-07-02 to cover all 14 `conductor/code_styleguides/*.md`):** - `AGENTS.md` — "Critical Anti-Patterns", "File Size and Naming Convention", "Session-Learned Anti-Patterns", "Process Anti-Patterns" - `conductor/workflow.md` — "Code Style", "Guiding Principles", "Testing Requirements", "Known Pitfalls", "Process Anti-Patterns", "Tier 2 Autonomous Sandbox conventions" - `conductor/product-guidelines.md` — "Core Value", "Code Standards & Architecture", "Data-Oriented Error Handling", "Phase 5: Heavy Curation" @@ -145,9 +145,16 @@ The directives are NOT limited to the 11 files the role prompts mandate. They're - `conductor/code_styleguides/rag_integration_discipline.md` — "conservative-RAG rule" - `conductor/code_styleguides/cache_friendly_context.md` — stable-to-volatile ordering - `conductor/code_styleguides/knowledge_artifacts.md` — the harvest pattern +- `conductor/code_styleguides/config_state_owner.md` — AppController is the single source of truth for config I/O (directive: no `models.save_config`/`models.load_config` in `src/`; enforced by `scripts/audit_no_models_config_io.py`) +- `conductor/code_styleguides/workspace_paths.md` — test-infrastructure paths must live under `./tests/` (directive: no `tmp_path_factory.mktemp`, no env vars for test paths, no CLI args for test paths; conftest is the right place) +- `conductor/code_styleguides/test_sandbox.md` — the test-sandbox hardening conventions (FR1 runtime guard, FR2 live_gui workspace fixture, FR3 sync coalescing) +- `conductor/code_styleguides/chroma_cache.md` — ChromaDB cache conventions (if directive-like content present) +- `conductor/code_styleguides/code_path_audit.md` — the per-aggregate data-pipeline audit convention - `docs/AGENTS.md` — "Convention Enforcement" - `docs/Readme.md` — any directive-like content in feature descriptions +> **Note (added 2026-07-02):** the original source list named 9 of the 14 styleguides. The 5 added here (`config_state_owner.md`, `workspace_paths.md`, `test_sandbox.md`, `chroma_cache.md`, `code_path_audit.md`) contain directive-like content that should be harvested. The harvester should verify each contains a harvestable directive before creating a `v1.md`; if a styleguide is purely descriptive (no imperative/ban/preference), skip it and note the skip in the harvest commit. + **Granularity resolution:** the harvest produces a candidate list. Then the question of which directives to merge (e.g., `ban_prefix_aliasing` + `no_local_imports` might become `import_hygiene`), split, or keep standalone is resolved in the harvest phase — not locked in upfront. ### The original docs stay untouched @@ -220,7 +227,7 @@ The video analysis track is initialized as a separate conductor track (`video_an ## See Also -- `conductor/tier2/agents/tier2-autonomous.md` — the role prompt that will be updated with `warm with:` +- `conductor/tier2/agents/tier2-autonomous.md` — the role prompt that will be updated with `warm with:` (verified present 2026-07-02; 17,940 bytes) - `conductor/tier2/commands/tier-2-auto-execute.md` — the slash command template - `conductor/code_styleguides/python.md` §17 — the primary source of directives to harvest - `conductor/code_styleguides/error_handling.md` — the Result[T] convention to harvest