From a2bbc8f0b3123881f7e3e9bc56369273d851271b Mon Sep 17 00:00:00 2001 From: Ed_ Date: Sun, 21 Jun 2026 09:23:49 -0400 Subject: [PATCH] fix(baseline): force-commit 3 PHASE1_INVENTORY_*.md docs (gitignore-exempted) The 3 per-file inventory docs were created in sub-track 5 commit 102f2199 (force-added despite tests/artifacts/ being in .gitignore) but the inventory docs themselves were never explicitly committed. They were left in the working tree and lost when the working tree rebuilt. This commit force-adds the 3 docs (bypassing the .gitignore block that does 'ignore everything in tests/artifacts/') so the test file's expectations at lines 20-22 are satisfied: INV_MCP = Path('tests/artifacts/PHASE1_INVENTORY_mcp_client.md') # 5354 bytes INV_AI = Path('tests/artifacts/PHASE1_INVENTORY_ai_client.md') # 5667 bytes INV_RAG = Path('tests/artifacts/PHASE1_INVENTORY_rag_engine.md') # 1945 bytes Each > 500 bytes (the test's minimum size check). The 31/31 baseline test count is now REAL: the JSON is committed (b3508f0b), the inventory docs are committed (this commit), and the test scaffolding is portable across fresh working trees. The user's Round 5 reported 1 test failing because they were testing on a fresh tree (or the remote branch) where the inventory docs were missing. This commit fixes that. --- tests/artifacts/PHASE1_INVENTORY_ai_client.md | 89 +++++++++++++++++++ .../artifacts/PHASE1_INVENTORY_mcp_client.md | 82 +++++++++++++++++ .../artifacts/PHASE1_INVENTORY_rag_engine.md | 43 +++++++++ 3 files changed, 214 insertions(+) create mode 100644 tests/artifacts/PHASE1_INVENTORY_ai_client.md create mode 100644 tests/artifacts/PHASE1_INVENTORY_mcp_client.md create mode 100644 tests/artifacts/PHASE1_INVENTORY_rag_engine.md diff --git a/tests/artifacts/PHASE1_INVENTORY_ai_client.md b/tests/artifacts/PHASE1_INVENTORY_ai_client.md new file mode 100644 index 00000000..a0778337 --- /dev/null +++ b/tests/artifacts/PHASE1_INVENTORY_ai_client.md @@ -0,0 +1,89 @@ +# Phase 1 Site Inventory — ai_client.py + +**File:** `src/ai_client.py` +**Source:** `tests/artifacts/PHASE1_AUDIT_BASELINE.json` (audit `--include-baseline`) +**Total sites in audit:** 59 +**Migration-target sites:** 33 +**Stay-as-is sites:** 26 + +## Category Breakdown + +| Category | Count | +|---|---| +| BOUNDARY_CONVERSION (stay) | 1 | +| BOUNDARY_SDK (stay) | 4 | +| INTERNAL_BROAD_CATCH (MIGRATION) | 17 | +| INTERNAL_COMPLIANT (stay) | 17 | +| INTERNAL_PROGRAMMER_RAISE (stay) | 4 | +| INTERNAL_RETHROW (MIGRATION) | 7 | +| INTERNAL_SILENT_SWALLOW (MIGRATION) | 9 | + +## Migration-Target Sites + +| # | Line | Category | Code excerpt | Phase bucket | +|---|---|---|---|---| +| 1 | L277 | INTERNAL_RETHROW | `_load_credentials` (RAISE) | Phase 12 (ai) / Phase 13 (rag) | +| 2 | L302 | INTERNAL_SILENT_SWALLOW | `_classify_anthropic_error` (EXCEPT) | Phase 8 (mcp) / Phase 11 (ai) / Phase 13 (rag) | +| 3 | L314 | INTERNAL_SILENT_SWALLOW | `_classify_gemini_error` (EXCEPT) | Phase 8 (mcp) / Phase 11 (ai) / Phase 13 (rag) | +| 4 | L332 | INTERNAL_BROAD_CATCH | `_classify_deepseek_error` (EXCEPT) | Batch (Phase 3-7) | +| 5 | L355 | INTERNAL_BROAD_CATCH | `_classify_minimax_error` (EXCEPT) | Batch (Phase 3-7) | +| 6 | L394 | INTERNAL_BROAD_CATCH | `set_provider` (EXCEPT) | Batch (Phase 3-7) | +| 7 | L414 | INTERNAL_SILENT_SWALLOW | `cleanup` (EXCEPT) | Phase 8 (mcp) / Phase 11 (ai) / Phase 13 (rag) | +| 8 | L432 | INTERNAL_SILENT_SWALLOW | `reset_session` (EXCEPT) | Phase 8 (mcp) / Phase 11 (ai) / Phase 13 (rag) | +| 9 | L520 | INTERNAL_BROAD_CATCH | `set_tool_preset` (EXCEPT) | Batch (Phase 3-7) | +| 10 | L537 | INTERNAL_BROAD_CATCH | `set_bias_profile` (EXCEPT) | Batch (Phase 3-7) | +| 11 | L716 | INTERNAL_BROAD_CATCH | `_execute_tool_calls_concurrently` (EXCEPT) | Batch (Phase 3-7) | +| 12 | L723 | INTERNAL_BROAD_CATCH | `_execute_tool_calls_concurrently` (EXCEPT) | Batch (Phase 3-7) | +| 13 | L801 | INTERNAL_RETHROW | `_default_send` (RAISE) | Phase 12 (ai) / Phase 13 (rag) | +| 14 | L802 | INTERNAL_RETHROW | `_default_send` (RAISE) | Phase 12 (ai) / Phase 13 (rag) | +| 15 | L994 | INTERNAL_BROAD_CATCH | `_reread_file_items` (EXCEPT) | Batch (Phase 3-7) | +| 16 | L1234 | INTERNAL_RETHROW | `_list_anthropic_models` (RAISE) | Phase 12 (ai) / Phase 13 (rag) | +| 17 | L1528 | INTERNAL_BROAD_CATCH | `_list_gemini_models` (EXCEPT) | Batch (Phase 3-7) | +| 18 | L1529 | INTERNAL_RETHROW | `_list_gemini_models` (RAISE) | Phase 12 (ai) / Phase 13 (rag) | +| 19 | L1555 | INTERNAL_SILENT_SWALLOW | `_extract_gemini_thoughts` (EXCEPT) | Phase 8 (mcp) / Phase 11 (ai) / Phase 13 (rag) | +| 20 | L1599 | INTERNAL_BROAD_CATCH | `_send_gemini` (EXCEPT) | Batch (Phase 3-7) | +| 21 | L1611 | INTERNAL_BROAD_CATCH | `_send_gemini` (EXCEPT) | Batch (Phase 3-7) | +| 22 | L1636 | INTERNAL_BROAD_CATCH | `_send_gemini` (EXCEPT) | Batch (Phase 3-7) | +| 23 | L1657 | INTERNAL_BROAD_CATCH | `_send_gemini` (EXCEPT) | Batch (Phase 3-7) | +| 24 | L1854 | INTERNAL_BROAD_CATCH | `_send` (EXCEPT) | Batch (Phase 3-7) | +| 25 | L1856 | INTERNAL_RETHROW | `_send` (RAISE) | Phase 12 (ai) / Phase 13 (rag) | +| 26 | L2242 | INTERNAL_SILENT_SWALLOW | `_list_minimax_models` (EXCEPT) | Phase 8 (mcp) / Phase 11 (ai) / Phase 13 (rag) | +| 27 | L2520 | INTERNAL_RETHROW | `_dashscope_call` (RAISE) | Phase 12 (ai) / Phase 13 (rag) | +| 28 | L2848 | INTERNAL_BROAD_CATCH | `run_tier4_analysis` (EXCEPT) | Batch (Phase 3-7) | +| 29 | L2867 | INTERNAL_BROAD_CATCH | `run_tier4_patch_callback` (EXCEPT) | Batch (Phase 3-7) | +| 30 | L2898 | INTERNAL_BROAD_CATCH | `run_tier4_patch_generation` (EXCEPT) | Batch (Phase 3-7) | +| 31 | L2914 | INTERNAL_SILENT_SWALLOW | `get_token_stats` (EXCEPT) | Phase 8 (mcp) / Phase 11 (ai) / Phase 13 (rag) | +| 32 | L2922 | INTERNAL_SILENT_SWALLOW | `get_token_stats` (EXCEPT) | Phase 8 (mcp) / Phase 11 (ai) / Phase 13 (rag) | +| 33 | L3082 | INTERNAL_SILENT_SWALLOW | `` (EXCEPT) | Phase 8 (mcp) / Phase 11 (ai) / Phase 13 (rag) | + +## Stay-As-Is Sites + +| Line | Category | Code excerpt | +|---|---|---| +| L276 | BOUNDARY_SDK | `_load_credentials` (EXCEPT) | +| L828 | INTERNAL_COMPLIANT | `run_with_tool_loop` (EXCEPT) | +| L1233 | BOUNDARY_SDK | `_list_anthropic_models` (EXCEPT) | +| L1437 | INTERNAL_COMPLIANT | `_send_anthropic` (EXCEPT) | +| L1488 | INTERNAL_COMPLIANT | `_send_anthropic` (EXCEPT) | +| L1777 | INTERNAL_COMPLIANT | `_send_gemini` (EXCEPT) | +| L1809 | INTERNAL_COMPLIANT | `_send_gemini` (EXCEPT) | +| L1896 | INTERNAL_COMPLIANT | `_pre_dispatch` (EXCEPT) | +| L1926 | INTERNAL_COMPLIANT | `_send_gemini_cli` (EXCEPT) | +| L1989 | INTERNAL_PROGRAMMER_RAISE | `_send_deepseek` (RAISE) | +| L2071 | INTERNAL_COMPLIANT | `_send_deepseek` (EXCEPT) | +| L2125 | INTERNAL_COMPLIANT | `_send_deepseek` (EXCEPT) | +| L2184 | INTERNAL_COMPLIANT | `_send_deepseek` (EXCEPT) | +| L2222 | INTERNAL_COMPLIANT | `_send_deepseek` (EXCEPT) | +| L2299 | INTERNAL_PROGRAMMER_RAISE | `_ensure_minimax_client` (RAISE) | +| L2310 | INTERNAL_PROGRAMMER_RAISE | `_ensure_grok_client` (RAISE) | +| L2391 | INTERNAL_COMPLIANT | `_send_grok` (EXCEPT) | +| L2473 | INTERNAL_COMPLIANT | `_send_minimax` (EXCEPT) | +| L2487 | INTERNAL_PROGRAMMER_RAISE | `_ensure_qwen_client` (RAISE) | +| L2617 | INTERNAL_COMPLIANT | `_send_qwen` (EXCEPT) | +| L2711 | INTERNAL_COMPLIANT | `_send_llama` (EXCEPT) | +| L2799 | INTERNAL_COMPLIANT | `_send_llama_native` (EXCEPT) | +| L2813 | INTERNAL_COMPLIANT | `_get_llama_cost_tracking` (EXCEPT) | +| L3057 | BOUNDARY_CONVERSION | `send` (EXCEPT) | +| L3133 | BOUNDARY_SDK | `run_subagent_summarization` (EXCEPT) | +| L3174 | BOUNDARY_SDK | `run_discussion_compression` (EXCEPT) | + diff --git a/tests/artifacts/PHASE1_INVENTORY_mcp_client.md b/tests/artifacts/PHASE1_INVENTORY_mcp_client.md new file mode 100644 index 00000000..efde931c --- /dev/null +++ b/tests/artifacts/PHASE1_INVENTORY_mcp_client.md @@ -0,0 +1,82 @@ +# Phase 1 Site Inventory — mcp_client.py + +**File:** `src/mcp_client.py` +**Source:** `tests/artifacts/PHASE1_AUDIT_BASELINE.json` (audit `--include-baseline`) +**Total sites in audit:** 55 +**Migration-target sites:** 46 +**Stay-as-is sites:** 9 + +## Category Breakdown + +| Category | Count | +|---|---| +| INTERNAL_BROAD_CATCH (MIGRATION) | 40 | +| INTERNAL_COMPLIANT (stay) | 9 | +| INTERNAL_SILENT_SWALLOW (MIGRATION) | 5 | +| UNCLEAR (MIGRATION) | 1 | + +## Migration-Target Sites + +| # | Line | Category | Code excerpt | Phase bucket | +|---|---|---|---|---| +| 1 | L171 | INTERNAL_SILENT_SWALLOW | `_is_allowed` (EXCEPT) | Phase 8 (mcp) / Phase 11 (ai) / Phase 13 (rag) | +| 2 | L191 | INTERNAL_BROAD_CATCH | `_resolve_and_check` (EXCEPT) | Batch (Phase 3-7) | +| 3 | L229 | INTERNAL_BROAD_CATCH | `search_files` (EXCEPT) | Batch (Phase 3-7) | +| 4 | L254 | INTERNAL_BROAD_CATCH | `list_directory` (EXCEPT) | Batch (Phase 3-7) | +| 5 | L266 | INTERNAL_BROAD_CATCH | `read_file` (EXCEPT) | Batch (Phase 3-7) | +| 6 | L395 | INTERNAL_BROAD_CATCH | `edit_file` (EXCEPT) | Batch (Phase 3-7) | +| 7 | L414 | INTERNAL_BROAD_CATCH | `get_file_summary` (EXCEPT) | Batch (Phase 3-7) | +| 8 | L430 | INTERNAL_BROAD_CATCH | `get_file_slice` (EXCEPT) | Batch (Phase 3-7) | +| 9 | L451 | INTERNAL_BROAD_CATCH | `set_file_slice` (EXCEPT) | Batch (Phase 3-7) | +| 10 | L473 | INTERNAL_BROAD_CATCH | `get_git_diff` (EXCEPT) | Batch (Phase 3-7) | +| 11 | L492 | INTERNAL_BROAD_CATCH | `ts_c_get_skeleton` (EXCEPT) | Batch (Phase 3-7) | +| 12 | L509 | INTERNAL_BROAD_CATCH | `ts_c_get_code_outline` (EXCEPT) | Batch (Phase 3-7) | +| 13 | L523 | INTERNAL_BROAD_CATCH | `ts_c_get_definition` (EXCEPT) | Batch (Phase 3-7) | +| 14 | L537 | INTERNAL_BROAD_CATCH | `ts_c_get_signature` (EXCEPT) | Batch (Phase 3-7) | +| 15 | L555 | INTERNAL_BROAD_CATCH | `ts_c_update_definition` (EXCEPT) | Batch (Phase 3-7) | +| 16 | L576 | INTERNAL_BROAD_CATCH | `ts_cpp_get_skeleton` (EXCEPT) | Batch (Phase 3-7) | +| 17 | L593 | INTERNAL_BROAD_CATCH | `ts_cpp_get_code_outline` (EXCEPT) | Batch (Phase 3-7) | +| 18 | L610 | INTERNAL_BROAD_CATCH | `ts_cpp_get_definition` (EXCEPT) | Batch (Phase 3-7) | +| 19 | L624 | INTERNAL_BROAD_CATCH | `ts_cpp_get_signature` (EXCEPT) | Batch (Phase 3-7) | +| 20 | L645 | INTERNAL_BROAD_CATCH | `ts_cpp_update_definition` (EXCEPT) | Batch (Phase 3-7) | +| 21 | L695 | INTERNAL_BROAD_CATCH | `py_get_skeleton` (EXCEPT) | Batch (Phase 3-7) | +| 22 | L713 | INTERNAL_BROAD_CATCH | `py_get_code_outline` (EXCEPT) | Batch (Phase 3-7) | +| 23 | L739 | INTERNAL_BROAD_CATCH | `py_get_symbol_info` (EXCEPT) | Batch (Phase 3-7) | +| 24 | L768 | INTERNAL_BROAD_CATCH | `py_get_definition` (EXCEPT) | Batch (Phase 3-7) | +| 25 | L788 | INTERNAL_BROAD_CATCH | `py_update_definition` (EXCEPT) | Batch (Phase 3-7) | +| 26 | L818 | INTERNAL_BROAD_CATCH | `py_get_signature` (EXCEPT) | Batch (Phase 3-7) | +| 27 | L843 | INTERNAL_BROAD_CATCH | `py_set_signature` (EXCEPT) | Batch (Phase 3-7) | +| 28 | L872 | INTERNAL_BROAD_CATCH | `py_get_class_summary` (EXCEPT) | Batch (Phase 3-7) | +| 29 | L893 | INTERNAL_BROAD_CATCH | `py_get_var_declaration` (EXCEPT) | Batch (Phase 3-7) | +| 30 | L913 | INTERNAL_BROAD_CATCH | `py_set_var_declaration` (EXCEPT) | Batch (Phase 3-7) | +| 31 | L936 | INTERNAL_SILENT_SWALLOW | `_search_file` (EXCEPT) | Phase 8 (mcp) / Phase 11 (ai) / Phase 13 (rag) | +| 32 | L951 | INTERNAL_BROAD_CATCH | `py_find_usages` (EXCEPT) | Batch (Phase 3-7) | +| 33 | L974 | INTERNAL_BROAD_CATCH | `py_get_imports` (EXCEPT) | Batch (Phase 3-7) | +| 34 | L987 | UNCLEAR | `py_check_syntax` (EXCEPT) | Phase 8 (mcp) | +| 35 | L989 | INTERNAL_BROAD_CATCH | `py_check_syntax` (EXCEPT) | Batch (Phase 3-7) | +| 36 | L1012 | INTERNAL_SILENT_SWALLOW | `_search_file` (EXCEPT) | Phase 8 (mcp) / Phase 11 (ai) / Phase 13 (rag) | +| 37 | L1026 | INTERNAL_BROAD_CATCH | `py_get_hierarchy` (EXCEPT) | Batch (Phase 3-7) | +| 38 | L1047 | INTERNAL_BROAD_CATCH | `py_get_docstring` (EXCEPT) | Batch (Phase 3-7) | +| 39 | L1071 | INTERNAL_BROAD_CATCH | `derive_code_path` (EXCEPT) | Batch (Phase 3-7) | +| 40 | L1106 | INTERNAL_BROAD_CATCH | `trace` (EXCEPT) | Batch (Phase 3-7) | +| 41 | L1140 | INTERNAL_BROAD_CATCH | `get_tree` (EXCEPT) | Batch (Phase 3-7) | +| 42 | L1223 | INTERNAL_BROAD_CATCH | `web_search` (EXCEPT) | Batch (Phase 3-7) | +| 43 | L1249 | INTERNAL_BROAD_CATCH | `fetch_url` (EXCEPT) | Batch (Phase 3-7) | +| 44 | L1268 | INTERNAL_BROAD_CATCH | `get_ui_performance` (EXCEPT) | Batch (Phase 3-7) | +| 45 | L1311 | INTERNAL_SILENT_SWALLOW | `stop` (EXCEPT) | Phase 8 (mcp) / Phase 11 (ai) / Phase 13 (rag) | +| 46 | L1316 | INTERNAL_SILENT_SWALLOW | `stop` (EXCEPT) | Phase 8 (mcp) / Phase 11 (ai) / Phase 13 (rag) | + +## Stay-As-Is Sites + +| Line | Category | Code excerpt | +|---|---|---| +| L126 | INTERNAL_COMPLIANT | `configure` (EXCEPT) | +| L152 | INTERNAL_COMPLIANT | `_is_allowed` (EXCEPT) | +| L177 | INTERNAL_COMPLIANT | `_is_allowed` (EXCEPT) | +| L276 | INTERNAL_COMPLIANT | `_resolve_and_check_result` (EXCEPT) | +| L307 | INTERNAL_COMPLIANT | `read_file_result` (EXCEPT) | +| L335 | INTERNAL_COMPLIANT | `list_directory_result` (EXCEPT) | +| L363 | INTERNAL_COMPLIANT | `search_files_result` (EXCEPT) | +| L471 | INTERNAL_COMPLIANT | `get_git_diff` (EXCEPT) | +| L1126 | INTERNAL_COMPLIANT | `_build_tree` (EXCEPT) | + diff --git a/tests/artifacts/PHASE1_INVENTORY_rag_engine.md b/tests/artifacts/PHASE1_INVENTORY_rag_engine.md new file mode 100644 index 00000000..ff374fc1 --- /dev/null +++ b/tests/artifacts/PHASE1_INVENTORY_rag_engine.md @@ -0,0 +1,43 @@ +# Phase 1 Site Inventory — rag_engine.py + +**File:** `src/rag_engine.py` +**Source:** `tests/artifacts/PHASE1_AUDIT_BASELINE.json` (audit `--include-baseline`) +**Total sites in audit:** 15 +**Migration-target sites:** 9 +**Stay-as-is sites:** 6 + +## Category Breakdown + +| Category | Count | +|---|---| +| INTERNAL_BROAD_CATCH (MIGRATION) | 5 | +| INTERNAL_COMPLIANT (stay) | 1 | +| INTERNAL_PROGRAMMER_RAISE (stay) | 5 | +| INTERNAL_RETHROW (MIGRATION) | 3 | +| INTERNAL_SILENT_SWALLOW (MIGRATION) | 1 | + +## Migration-Target Sites + +| # | Line | Category | Code excerpt | Phase bucket | +|---|---|---|---|---| +| 1 | L29 | INTERNAL_RETHROW | `_get_sentence_transformers` (EXCEPT) | Phase 12 (ai) / Phase 13 (rag) | +| 2 | L32 | INTERNAL_RETHROW | `_get_sentence_transformers` (RAISE) | Phase 12 (ai) / Phase 13 (rag) | +| 3 | L33 | INTERNAL_BROAD_CATCH | `_get_sentence_transformers` (EXCEPT) | Batch (Phase 3-7) | +| 4 | L36 | INTERNAL_RETHROW | `_get_sentence_transformers` (RAISE) | Phase 12 (ai) / Phase 13 (rag) | +| 5 | L224 | INTERNAL_BROAD_CATCH | `_chunk_code` (EXCEPT) | Batch (Phase 3-7) | +| 6 | L247 | INTERNAL_BROAD_CATCH | `index_file` (EXCEPT) | Batch (Phase 3-7) | +| 7 | L255 | INTERNAL_SILENT_SWALLOW | `index_file` (EXCEPT) | Phase 8 (mcp) / Phase 11 (ai) / Phase 13 (rag) | +| 8 | L261 | INTERNAL_BROAD_CATCH | `index_file` (EXCEPT) | Batch (Phase 3-7) | +| 9 | L290 | INTERNAL_BROAD_CATCH | `_async_search_mcp` (EXCEPT) | Batch (Phase 3-7) | + +## Stay-As-Is Sites + +| Line | Category | Code excerpt | +|---|---|---| +| L31 | INTERNAL_PROGRAMMER_RAISE | `_get_sentence_transformers` (RAISE) | +| L57 | INTERNAL_PROGRAMMER_RAISE | `embed` (RAISE) | +| L75 | INTERNAL_PROGRAMMER_RAISE | `embed` (RAISE) | +| L80 | INTERNAL_PROGRAMMER_RAISE | `embed` (RAISE) | +| L109 | INTERNAL_PROGRAMMER_RAISE | `_init_embedding_provider` (RAISE) | +| L165 | INTERNAL_COMPLIANT | `_validate_collection_dim_result` (EXCEPT) | +