From 98ece4d1663e583c5f9be11ee89fb1cbdf873067 Mon Sep 17 00:00:00 2001 From: Ed_ Date: Fri, 12 Jun 2026 16:07:38 -0400 Subject: [PATCH] conductor(track-update): data_oriented_error_handling - doc sync 2026-06-12 forward-references Add forward-references to the 5 new canonical sources added by the 2026-06-12 doc sync (commits 35c6cca1 + 434b6d0d): data_oriented_design.md, agent_memory_dimensions.md, rag_integration_discipline.md, knowledge_artifacts.md, docs/AGENTS.md. All 5 cite this track as the canonical error-handling convention; the 4 memory dimensions and 12 nagent TDD protocols are orthogonal to error handling so no plan changes were needed. Verification recorded in state.toml [doc_sync_20260612]. --- .../plan.md | 2 + .../spec.md | 5 +++ .../state.toml | 40 +++++++++++++++++++ 3 files changed, 47 insertions(+) diff --git a/conductor/tracks/data_oriented_error_handling_20260606/plan.md b/conductor/tracks/data_oriented_error_handling_20260606/plan.md index 9d6af9bc..b421a845 100644 --- a/conductor/tracks/data_oriented_error_handling_20260606/plan.md +++ b/conductor/tracks/data_oriented_error_handling_20260606/plan.md @@ -511,6 +511,8 @@ When converting existing code: - `conductor/tracks/data_oriented_error_handling_20260606/spec.md` — the spec that established this convention - `docs/guide_ai_client.md` "Data-Oriented Error Handling (Fleury Pattern)" — the in-context guide for the provider layer - `docs/guide_mcp_client.md` — the in-context guide for the MCP tool layer +- `conductor/code_styleguides/data_oriented_design.md` (added 2026-06-12) — the canonical DOD reference; this track is the canonical application of DOD to error handling +- `conductor/code_styleguides/agent_memory_dimensions.md` (added 2026-06-12) — the 4-dim memory model; the knowledge harvest TDD protocol in `workflow.md` uses this track's `Result` pattern - Ryan Fleury's [original article](https://www.dgtlgrove.com/p/the-easiest-way-to-handle-errors) — the philosophical foundation ``` diff --git a/conductor/tracks/data_oriented_error_handling_20260606/spec.md b/conductor/tracks/data_oriented_error_handling_20260606/spec.md index 99d4ec45..871b6002 100644 --- a/conductor/tracks/data_oriented_error_handling_20260606/spec.md +++ b/conductor/tracks/data_oriented_error_handling_20260606/spec.md @@ -707,6 +707,11 @@ Plus **63** test files (verified 2026-06-11) that call `send()` directly. The fo - `conductor/tracks/nagent_review_20260608/report.md` — added 2026-06-08. §15 Pitfalls #2 and #4 (per-provider history globals, stateful singleton) and Pitfall #9 (sub-conversations) inform this track's risk register. Pitfall #4 specifically motivates the new `ErrorKind.PROVIDER_HISTORY_DIVERGED_FROM_UI` kind. - `conductor/tracks/nagent_review_20260608/nagent_takeaways_20260608.md` — added 2026-06-08. §9 ("Edit-the-input, not the output") describes the same provider-history-divergence problem; the `Result` pattern + the new error kind are the data-oriented solution. - `conductor/tracks/test_batching_refactor_20260606/` — the previous track that established the "tier-based" pattern; this track uses the same convention format (spec + metadata + state + plan). +- `conductor/code_styleguides/data_oriented_design.md` — added 2026-06-12. The canonical Data-Oriented Design (DOD) reference for Manual Slop; this track is the canonical application of DOD to error handling ("errors are data, not control flow"). Cites the `Result[T, ErrorInfo]` pattern at line 249 as a key data-oriented example. +- `conductor/code_styleguides/agent_memory_dimensions.md` — added 2026-06-12. The 4 memory dimensions (curation / discussion / RAG / knowledge). Cites this track at line 254 ("A query model that returns 'data, not control flow'"). The `Result` pattern is the canonical error envelope for the knowledge harvest TDD protocol in `workflow.md`. +- `conductor/code_styleguides/rag_integration_discipline.md` — added 2026-06-12. Cites this track at line 214 ("The exception is `Result[T, ErrorInfo]`, not an exception. Per the `data_oriented_error_handling_20260606` convention."). The RAG discipline TDD protocol in `workflow.md` requires graceful `Result.empty` returns on failure, not exceptions. +- `conductor/code_styleguides/knowledge_artifacts.md` — added 2026-06-12. Cites this track at line 408 ("the `Result[T, ErrorInfo]` pattern for the harvest LLM call"). The knowledge harvest TDD protocol in `workflow.md` returns `Result[list[CategoryRow], ErrorInfo]` from the LLM distillation call. +- `docs/AGENTS.md` — added 2026-06-12. The agent-facing mirror of `docs/Readme.md`; provides the per-tier reading path and references the 6-styleguide catalog. This track's `error_handling.md` is one of the 6 canonical styleguides. ### 12.4 External References diff --git a/conductor/tracks/data_oriented_error_handling_20260606/state.toml b/conductor/tracks/data_oriented_error_handling_20260606/state.toml index 962d425f..3c24087e 100644 --- a/conductor/tracks/data_oriented_error_handling_20260606/state.toml +++ b/conductor/tracks/data_oriented_error_handling_20260606/state.toml @@ -171,3 +171,43 @@ send_callsites_to_migrate = 0 # fill at end of Phase 3 = number of test files up # Per-vendor refactor commits (Task 3.4.1 - 3.4.9) # Order: gemini, anthropic, deepseek, minimax, gemini_cli, qwen, llama, grok, llama_native send_renamed_commits = [] # one commit SHA per vendor, in order + +[doc_sync_20260612] +# Forward-reference verification against the 2026-06-12 doc sync. +# Per the "reduce redundant content; map references to canonical sources" pattern +# from commit 434b6d0d, the project consolidated canonical sources and added +# the 6-styleguide catalog + 4 memory dimensions + 12 nagent TDD protocols. +# +# This track's core scope (Result[T]/ErrorInfo/ErrorKind/NilPath/NilRAGState +# convention) is well-documented in `conductor/code_styleguides/error_handling.md` +# and is the canonical application of DOD to error handling. The new canonical +# references added 2026-06-12 cite this track: +# - data_oriented_design.md L249: "Ryan Fleury, 'Errors are just cases' +# (the Result[T, ErrorInfo] pattern)" +# - agent_memory_dimensions.md L254: "A query model that returns 'data, not +# control flow' (per data_oriented_error_handling_20260606)" +# - rag_integration_discipline.md L214: "The exception is Result[T, ErrorInfo], +# not an exception. Per the data_oriented_error_handling_20260606 convention." +# - knowledge_artifacts.md L408: "the Result[T, ErrorInfo] pattern for the +# harvest LLM call" +# - docs/AGENTS.md: the 6-styleguide catalog lists this track's +# error_handling.md as one of the 6 canonical styleguides. +# +# The 4 memory dimensions and 12 nagent TDD protocols do NOT apply to error +# handling (they are for memory subsystems: knowledge harvest, cache ordering, +# compaction, RAG discipline). No plan changes needed. +# +# Forward references added to spec.md §12.3 in this commit: +# - data_oriented_design.md +# - agent_memory_dimensions.md +# - rag_integration_discipline.md +# - knowledge_artifacts.md +# - docs/AGENTS.md +# Forward references added to plan.md "See Also" in this commit: +# - data_oriented_design.md +# - agent_memory_dimensions.md +doc_sync_aligned = true +last_verified = "2026-06-12" +no_plan_changes = true # the 4 memory dims + 12 nagent TDD protocols are orthogonal to error handling +no_spec_changes_to_design = true # only See Also cross-references added +commit_sha = "" # filled after commit