From 7a6ffd895458a3904bbc505a4ead263b31610f25 Mon Sep 17 00:00:00 2001 From: Ed_ Date: Mon, 15 Jun 2026 16:21:08 -0400 Subject: [PATCH] test(run_worker_lifecycle_abort): mock send_result not send (Phase 2.17, pre-empts Phase 1.3 regression) Phase 1.3 migrated run_worker_lifecycle to send_result(). This test mocks src.ai_client.send and asserts it is NOT called (abort fires before the AI dispatch). Migrating the mock to send_result is purely for consistency and future-proofing; the test still passes either way. Changes: - Rename patch(src.ai_client.send) to patch(src.ai_client.send_result) - Rename mock_send to mock_send_result - Comment updated to reference send_result --- tests/test_run_worker_lifecycle_abort.py | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/tests/test_run_worker_lifecycle_abort.py b/tests/test_run_worker_lifecycle_abort.py index 2aa75c3e..9cb3c7e3 100644 --- a/tests/test_run_worker_lifecycle_abort.py +++ b/tests/test_run_worker_lifecycle_abort.py @@ -9,13 +9,12 @@ from src.models import Ticket, WorkerContext class TestRunWorkerLifecycleAbort(unittest.TestCase): def test_run_worker_lifecycle_returns_early_on_abort(self): """ - - - Test that run_worker_lifecycle returns early and marks ticket as 'killed' - if the abort event is set for the ticket. + + Test that run_worker_lifecycle returns early and marks ticket as 'killed' + if the abort event is set for the ticket. """ - # Mock ai_client.send - with patch('src.ai_client.send') as mock_send: + # Mock ai_client.send_result + with patch('src.ai_client.send_result') as mock_send_result: # Mock ticket and context ticket = Ticket(id="T-001", description="Test task") ticket = Ticket(id="T-001", description="Test task") @@ -24,19 +23,19 @@ class TestRunWorkerLifecycleAbort(unittest.TestCase): mock_engine = MagicMock() abort_event = threading.Event() mock_engine._abort_events = {"T-001": abort_event} - + # Set abort event abort_event.set() - + # Call run_worker_lifecycle # md_content is expected to be passed if called like in ConductorEngine run_worker_lifecycle(ticket, context, engine=mock_engine, md_content="test context") - + # Assert ticket status is 'killed' self.assertEqual(ticket.status, "killed") - - # Also assert ai_client.send was NOT called - mock_send.assert_not_called() + + # Also assert ai_client.send_result was NOT called (abort fires before the call) + mock_send_result.assert_not_called() if __name__ == "__main__": unittest.main() \ No newline at end of file