From 6f279bc650b2b949824d2f3b9e0b6440bb339ad6 Mon Sep 17 00:00:00 2001 From: Ed_ Date: Mon, 2 Mar 2026 20:46:43 -0500 Subject: [PATCH] chore(conductor): Archive track 'Conductor Workflow Improvements' --- .../index.md | 5 +++++ .../metadata.json | 8 ++++++++ .../plan.md | 17 +++++++++++++++++ .../spec.md | 19 +++++++++++++++++++ conductor/tracks.md | 2 +- 5 files changed, 50 insertions(+), 1 deletion(-) create mode 100644 conductor/archive/conductor_workflow_improvements_20260302/index.md create mode 100644 conductor/archive/conductor_workflow_improvements_20260302/metadata.json create mode 100644 conductor/archive/conductor_workflow_improvements_20260302/plan.md create mode 100644 conductor/archive/conductor_workflow_improvements_20260302/spec.md diff --git a/conductor/archive/conductor_workflow_improvements_20260302/index.md b/conductor/archive/conductor_workflow_improvements_20260302/index.md new file mode 100644 index 0000000..ad6e45e --- /dev/null +++ b/conductor/archive/conductor_workflow_improvements_20260302/index.md @@ -0,0 +1,5 @@ +# Track conductor_workflow_improvements_20260302 Context + +- [Specification](./spec.md) +- [Implementation Plan](./plan.md) +- [Metadata](./metadata.json) \ No newline at end of file diff --git a/conductor/archive/conductor_workflow_improvements_20260302/metadata.json b/conductor/archive/conductor_workflow_improvements_20260302/metadata.json new file mode 100644 index 0000000..5e21c81 --- /dev/null +++ b/conductor/archive/conductor_workflow_improvements_20260302/metadata.json @@ -0,0 +1,8 @@ +{ + "track_id": "conductor_workflow_improvements_20260302", + "type": "chore", + "status": "new", + "created_at": "2026-03-02T00:00:00Z", + "updated_at": "2026-03-02T00:00:00Z", + "description": "Improve MMA Skill prompts and Conductor workflow docs to enforce TDD, prevent feature bleed, and force mandatory pre-implementation architecture audits." +} \ No newline at end of file diff --git a/conductor/archive/conductor_workflow_improvements_20260302/plan.md b/conductor/archive/conductor_workflow_improvements_20260302/plan.md new file mode 100644 index 0000000..ff3d570 --- /dev/null +++ b/conductor/archive/conductor_workflow_improvements_20260302/plan.md @@ -0,0 +1,17 @@ +# Implementation Plan: Conductor Workflow Improvements + +Architecture reference: [docs/guide_mma.md](../../../docs/guide_mma.md) + +--- + +## Phase 1: Skill Document Hardening [checkpoint: 3800347] +Focus: Update the agent skill prompts to enforce strict discipline. + +- [x] Task 1.1: Update `.gemini/skills/mma-tier2-tech-lead/SKILL.md`. Add a new section `## Anti-Entropy Protocol` requiring the Tech Lead to: (1) Use `py_get_code_outline` on the target class's `__init__` to check for redundant state before adding new variables; (2) Ensure failing tests are written and executed *before* delegating implementation to Tier 3. 82cec19 +- [x] Task 1.2: Update `.gemini/skills/mma-tier3-worker/SKILL.md`. Add an explicit directive in the `## Responsibilities` section: "You MUST write a failing test and verify it fails (the Red phase) BEFORE writing any implementation code. Do NOT write tests that contain only `pass` or lack assertions." 87fa4ff + +## Phase 2: Workflow Documentation Updates [checkpoint: 608a4de] +Focus: Add safeguards to the global Conductor workflow. + +- [x] Task 2.1: Update `conductor/workflow.md`. In the `High-Signal Research Phase` section, add a requirement to audit class initializers (`__init__`) for existing, unused, or duplicate state variables before adding new ones. b00d9ff +- [x] Task 2.2: Update `conductor/workflow.md`. In the `Test-Driven Development` section, explicitly ban zero-assertion tests and state that a test is only valid if it contains assertions that test the behavioral change. e334cd0 \ No newline at end of file diff --git a/conductor/archive/conductor_workflow_improvements_20260302/spec.md b/conductor/archive/conductor_workflow_improvements_20260302/spec.md new file mode 100644 index 0000000..4fd566d --- /dev/null +++ b/conductor/archive/conductor_workflow_improvements_20260302/spec.md @@ -0,0 +1,19 @@ +# Track Specification: Conductor Workflow Improvements + +## Overview +Recent Tier 2 track implementations have resulted in feature bleed, redundant code, unread state variables, and degradation of TDD discipline (e.g., zero-assertion tests). +This track updates the Conductor documentation (`workflow.md`) and the Gemini skills for Tiers 2 and 3 to hard-enforce TDD, prevent hallucinated "mock" implementations, and enforce strict codebase auditing before writing code. + +## Current State Audit +1. **Tier 2 Tech Lead Skill (`.gemini/skills/mma-tier2-tech-lead/SKILL.md`)**: Lacks explicit instructions forbidding the merging of code without verified failing test runs. Also lacks mandatory instructions to use `py_get_code_outline` or AST scans specifically to prevent duplicate state variables. +2. **Tier 3 Worker Skill (`.gemini/skills/mma-tier3-worker/SKILL.md`)**: Mentions TDD, but does not explicitly instruct the agent to refuse to write implementation code if failing tests haven't been written and executed first. +3. **Workflow Document (`conductor/workflow.md`)**: Mentions TDD and a Research-First Protocol, but lacks a strict "Zero-Assertion Prevention" rule and doesn't emphasize AST analysis of `__init__` functions when modifying state. + +## Desired State +- The `mma-tier2-tech-lead` skill forces the Tech Lead to execute tests and verify failure *before* delegating the implementation. It also mandates an explicit check of `__init__` for existing variables before adding new ones. +- The `mma-tier3-worker` skill includes an explicit safeguard: "Do NOT write implementation code if you have not first written and executed a failing test for it." +- The `conductor/workflow.md` explicitly calls out the danger of zero-assertion tests and requires AST checks for redundant state. + +## Technical Constraints +- The `.gemini/skills/` documents are the ultimate source of truth for agent behavior and must be updated directly. +- The updates should be clear, commanding, and reference the specific errors encountered (e.g., "feature bleed", "zero-assertion tests"). \ No newline at end of file diff --git a/conductor/tracks.md b/conductor/tracks.md index c76e200..f8d7a60 100644 --- a/conductor/tracks.md +++ b/conductor/tracks.md @@ -7,7 +7,7 @@ This file tracks all major tracks for the project. Each track has its own detail ## Completed / Archived - [x] **Track: Conductor Workflow Improvements** -*Link: [./tracks/conductor_workflow_improvements_20260302/](./tracks/conductor_workflow_improvements_20260302/)* +*Link: [./archive/conductor_workflow_improvements_20260302/](./archive/conductor_workflow_improvements_20260302/)* - [x] **Track: MMA Agent Focus UX** *Link: [./archive/mma_agent_focus_ux_20260302/](./archive/mma_agent_focus_ux_20260302/)*