From 60818b6c4eac1fbf47687f525d9cfaff1d309680 Mon Sep 17 00:00:00 2001 From: Ed_ Date: Thu, 18 Jun 2026 19:42:31 -0400 Subject: [PATCH] conductor(plan): Mark Task 2.1 complete (test scaffolding) Task 2.1: Created tests/test_app_controller_result.py with 5 Result-pattern tests. 2 pass, 3 fail as migration targets. Tests will turn green as Phase 2's 4 batches migrate the 32 INTERNAL_BROAD_CATCH sites. Refs: 142d0474 --- .../tracks/result_migration_app_controller_20260618/plan.md | 2 ++ .../tracks/result_migration_app_controller_20260618/state.toml | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/conductor/tracks/result_migration_app_controller_20260618/plan.md b/conductor/tracks/result_migration_app_controller_20260618/plan.md index 0a7eba93..d4c9d442 100644 --- a/conductor/tracks/result_migration_app_controller_20260618/plan.md +++ b/conductor/tracks/result_migration_app_controller_20260618/plan.md @@ -95,6 +95,8 @@ Focus: register the sub-track, then immediately fix the 2 known regressions (tes Focus: the main migration work. 32 sites, organized into 4 sub-batches by context (callback handlers, project ops, conductor ops, GUI tasks). Each sub-batch is 6-10 sites touching the same file; one commit per sub-batch. +- [x] **Task 2.1: Create `tests/test_app_controller_result.py` (the new test file)** [142d0474] + ### Task 2.1: Create `tests/test_app_controller_result.py` (the new test file) - **WHERE:** `tests/test_app_controller_result.py` (NEW) - **WHAT:** 5+ tests verifying Result return types for the migrated methods (placeholder tests that will be filled in as the migrations land). Initial tests can be: diff --git a/conductor/tracks/result_migration_app_controller_20260618/state.toml b/conductor/tracks/result_migration_app_controller_20260618/state.toml index a12a057f..27fcf37f 100644 --- a/conductor/tracks/result_migration_app_controller_20260618/state.toml +++ b/conductor/tracks/result_migration_app_controller_20260618/state.toml @@ -33,7 +33,7 @@ t1_5 = { status = "completed", commit_sha = "", description = "Run targeted regr t1_6 = { status = "pending", commit_sha = "", description = "Phase 1 checkpoint commit" } # Phase 2: Migrate 32 INTERNAL_BROAD_CATCH sites -t2_1 = { status = "pending", commit_sha = "", description = "Create tests/test_app_controller_result.py with 5 scaffolding tests" } +t2_1 = { status = "completed", commit_sha = "142d0474", description = "Create tests/test_app_controller_result.py with 5 scaffolding tests (2 pass, 3 fail as migration targets)" } t2_2 = { status = "pending", commit_sha = "", description = "Migrate batch 1: 5 callback-handler sites (L537, L579, L2046, L2068, L2081)" } t2_3 = { status = "pending", commit_sha = "", description = "Migrate batch 2: 6 project-op sites (L2129, L2140, L2154, L2195, L2890, L2944)" } t2_4 = { status = "pending", commit_sha = "", description = "Migrate batch 3: 8 conductor/track sites (L3057, L3084, L3094, L4237, L4349, L4446, L4475, L4504)" }