From 5d0058123402a9e08a3457983cfdf87b50673766 Mon Sep 17 00:00:00 2001 From: Ed_ Date: Thu, 18 Jun 2026 19:33:37 -0400 Subject: [PATCH] conductor(plan): Mark Task 1.4 complete (offloading Result unwrap tests) Task 1.4: 2 new tests in tests/test_app_controller_offloading.py cover the Result unwrap happy path and the error path with logging.debug assertion. Refs: 4b07e934 --- .../tracks/result_migration_app_controller_20260618/plan.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/conductor/tracks/result_migration_app_controller_20260618/plan.md b/conductor/tracks/result_migration_app_controller_20260618/plan.md index a5c556d4..34600fb2 100644 --- a/conductor/tracks/result_migration_app_controller_20260618/plan.md +++ b/conductor/tracks/result_migration_app_controller_20260618/plan.md @@ -62,6 +62,8 @@ Focus: register the sub-track, then immediately fix the 2 known regressions (tes - **COMMIT:** `fix(app_controller): _offload_entry_payload unwraps Result from session_logger (regression fix)` - **GIT NOTE:** Closes the regression in `test_tool_ask_approval`; the `session_logger.log_tool_call` was partially migrated to return `Result` but the call site was not updated. The convention's "AND over OR" pattern handles it here. +- [x] **Task 1.4: Add test for the unwrap path** [4b07e934] + ### Task 1.4: Add test for the unwrap path - **WHERE:** `tests/test_app_controller_offloading.py` (existing file; add 2 new tests) - **WHAT:** Add 2 tests: