From 4ac5b8ae2d1998133dddb24dfc2b648eb6981680 Mon Sep 17 00:00:00 2001 From: Ed_ Date: Wed, 17 Jun 2026 15:11:43 -0400 Subject: [PATCH] docs(track): result_migration_review_pass decisions for src/multi_agent_conductor.py UNCLEAR (1 compliant + 0 migration-target) --- docs/reports/RESULT_MIGRATION_REVIEW_PASS_20260617.md | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/docs/reports/RESULT_MIGRATION_REVIEW_PASS_20260617.md b/docs/reports/RESULT_MIGRATION_REVIEW_PASS_20260617.md index 3c56d1ce..6fdd96b7 100644 --- a/docs/reports/RESULT_MIGRATION_REVIEW_PASS_20260617.md +++ b/docs/reports/RESULT_MIGRATION_REVIEW_PASS_20260617.md @@ -123,7 +123,14 @@ Other audit findings (unchanged by this review pass): ### 2.6 `src/multi_agent_conductor.py` — UNCLEAR sites (1) -*(filled in Task 2.6)* +| Line | Context | Snippet | Decision | Pattern / Rationale | +|---|---|---|---|---| +| 236 | `parse_json_tickets` (CLI-style JSON input) | `except json.JSONDecodeError as e: print(...); except KeyError as e: print(...)` | **compliant** | CLI-style input parser: `print` provides user-visible error feedback; the function is `-> None` so there is no Result to add. The narrow excepts are appropriate for the two distinct failure modes (malformed JSON vs missing required field) | + +**Subtotals:** 1 compliant + 0 migration-target. + +**New heuristic candidates:** +10. `try/except (json.JSONDecodeError, KeyError)` around JSON parse with `print(...)` and `return` (no Result) → `INTERNAL_COMPLIANT` (CLI-style JSON input parser) ---