From 264b04f060743fd580214def93814dfe3a1bbed4 Mon Sep 17 00:00:00 2001 From: Ed_ Date: Mon, 2 Mar 2026 15:57:16 -0500 Subject: [PATCH] =?UTF-8?q?chore:=20close=20feature=5Fbleed=5Fcleanup=5F20?= =?UTF-8?q?260302=20=E2=80=94=20update=20TASKS.md=20and=20JOURNAL.md?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit All 3 phases complete and verified. 62 lines of dead code removed from gui_2.py. Meta-Level Sanity Check: 0 new ruff violations introduced. Next track: mma_agent_focus_ux_20260302 (dependency on Phase 1 now satisfied) --- JOURNAL.md | 14 ++++++++++++++ TASKS.md | 3 ++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/JOURNAL.md b/JOURNAL.md index e6d93dc..74fcced 100644 --- a/JOURNAL.md +++ b/JOURNAL.md @@ -47,6 +47,20 @@ - **Heuristics & Backlog**: Added Data-Oriented Design and Immediate Mode architectural heuristics (inspired by Muratori/Acton) to product-guidelines.md. Logged future decoupling and robust parsing tracks to a 'Future Backlog' in TASKS.md. --- +## 2026-03-02 (Session 3) + +### Track: feature_bleed_cleanup_20260302 — Completed |TASK:feature_bleed_cleanup_20260302| +- **What**: Removed all confirmed dead code and layout regressions from gui_2.py (3 phases) +- **Why**: Tier 3 workers had left behind dead duplicate methods, dead menu block, duplicate state vars, and a broken Token Budget layout that embedded the panel inside Provider & Model with double labels +- **How**: + - Phase 1: Deleted dead `_render_comms_history_panel` duplicate (stale `type` key, nonexistent `_cb_load_prior_log`, `scroll_area` ID collision). Deleted 4 duplicate `__init__` assignments (ui_new_track_name etc.) + - Phase 2: Deleted dead `begin_main_menu_bar()` block (24 lines, always-False in HelloImGui). Added working `Quit` to `_show_menus` via `runner_params.app_shall_exit = True` + - Phase 3: Removed 4 redundant Token Budget labels/call from `_render_provider_panel`. Added `collapsing_header("Token Budget")` to AI Settings with proper `_render_token_budget_panel()` call +- **Issues**: Full test suite hangs (pre-existing — `test_suite_performance_and_flakiness` backlog). Ran targeted GUI/MMA subset (32 passed) as regression proxy. Meta-Level Sanity Check: 52 ruff errors in gui_2.py before and after — zero new violations introduced +- **Result**: All 3 phases verified by user. Checkpoints: be7174c (Phase 1), 15fd786 (Phase 2), 0d081a2 (Phase 3) + +--- + diff --git a/TASKS.md b/TASKS.md index df768f5..e0bc156 100644 --- a/TASKS.md +++ b/TASKS.md @@ -3,9 +3,10 @@ ## Active Tracks -- `feature_bleed_cleanup_20260302` — Dead code & conflicting design state cleanup (Phase 1-3) +*(none — all planned tracks queued below)* ## Completed This Session +- `feature_bleed_cleanup_20260302` — Removed dead comms panel dup, dead menubar block, duplicate __init__ vars; added working Quit; fixed Token Budget layout. All phases verified. Checkpoint: 0d081a2. - `context_token_viz_20260301` — Token budget panel (color bar, breakdown table, trim warning, cache status, auto-refresh). All phases verified. Commit: d577457. ## Planned: Next Track