From 23862d358efd6563e33e2c562aac256b2faf166b Mon Sep 17 00:00:00 2001 From: Ed_ Date: Sat, 27 Jun 2026 14:14:58 -0400 Subject: [PATCH] chore(cleanup): remove all diagnostic instrumentation from app_controller MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Per edit_workflow.md ยง9 ('No Diagnostic Noise in Production Code'), the diag lines added in commits 75fdebb0 (stderr) and d046394a (file-based) are removed now that the root cause is identified and the fix is verified. The fix itself (TrackMetadata import) remains. Test continues to PASS at 7.81s. Production code restored to its pre-diagnostic shape. No [DEBUG_MMA_FIX] stderr writes, no [DIAG] log writes, no mma_diag.log references. --- src/app_controller.py | 38 -------------------------------------- 1 file changed, 38 deletions(-) diff --git a/src/app_controller.py b/src/app_controller.py index c0e681f7..846bdba8 100644 --- a/src/app_controller.py +++ b/src/app_controller.py @@ -4636,12 +4636,6 @@ class AppController: """ [C: src/gui_2.py:App._render_track_proposal_modal] """ - import os as _os - _dl = b"C:\\projects\\manual_slop_tier2\\tests\\artifacts\\tier2_state\\fix_mma_concurrent_tracks_sim_20260627\\mma_diag.log" - try: - with open(_dl, "ab") as _df: - _df.write(b"[DIAG] _cb_accept_tracks called\n") - except Exception: pass self._show_track_proposal_modal = False def _bg_task() -> "Result[None]": @@ -4674,10 +4668,6 @@ class AppController: return result # Now loop through tracks and call _start_track_logic with generated skeletons total_tracks = len(self.proposed_tracks) - try: - with open(b"C:\\projects\\manual_slop_tier2\\tests\\artifacts\\tier2_state\\fix_mma_concurrent_tracks_sim_20260627\\mma_diag.log", "ab") as _df: - _df.write(f"[DIAG] _bg_task ENTER total_tracks={total_tracks} proposed_ids={[(t.get(chr(105)+chr(100)) if isinstance(t, dict) else getattr(t, chr(105)+chr(100), chr(63))) for t in self.proposed_tracks]}\n".encode()) - except Exception: pass print(f"[DEBUG] _cb_accept_tracks: Starting {total_tracks} tracks...") for i, track_data in enumerate(self.proposed_tracks): title = track_data.get("title") or track_data.get("goal", "Untitled Track") @@ -4767,16 +4757,8 @@ class AppController: self.ai_status = f"Phase 2: Generating tickets for {title}..." skeletons = skeletons_str or "" # Use provided skeletons or empty self.ai_status = "Phase 2: Calling Tech Lead..." - try: - with open(b"C:\\projects\\manual_slop_tier2\\tests\\artifacts\\tier2_state\\fix_mma_concurrent_tracks_sim_20260627\\mma_diag.log", "ab") as _df: - _df.write(f"[DIAG] _start_track_logic_result ENTER title={title!r} goal={goal[:60]!r} skeletons_len={len(skeletons)}\n".encode()) - except Exception: pass _t2_baseline = len(ai_client.get_comms_log()) raw_tickets = conductor_tech_lead.generate_tickets(goal, skeletons) - try: - with open(b"C:\\projects\\manual_slop_tier2\\tests\\artifacts\\tier2_state\\fix_mma_concurrent_tracks_sim_20260627\\mma_diag.log", "ab") as _df: - _df.write(f"[DIAG] _start_track_logic_result AFTER generate_tickets title={title!r} raw_tickets_count={len(raw_tickets) if raw_tickets else 0}\n".encode()) - except Exception: pass _t2_new = ai_client.get_comms_log()[_t2_baseline:] _t2_resp = [e for e in _t2_new if e.get("direction") == "IN" and e.get("kind") == "response"] _t2_in = sum(e.get("payload", {}).get("usage", {}).get("input_tokens", 0) for e in _t2_resp) @@ -4796,16 +4778,8 @@ class AppController: print(f"Warning: No tickets generated for track: {title}") return OK self.ai_status = "Phase 2: Sorting tickets..." - try: - with open(b"C:\\projects\\manual_slop_tier2\\tests\\artifacts\\tier2_state\\fix_mma_concurrent_tracks_sim_20260627\\mma_diag.log", "ab") as _df: - _df.write(b"[DIAG] BEFORE _topological_sort_tickets_result\n") - except Exception: pass sort_result = self._topological_sort_tickets_result(raw_tickets, title) sorted_tickets_data = sort_result.data - try: - with open(b"C:\\projects\\manual_slop_tier2\\tests\\artifacts\\tier2_state\\fix_mma_concurrent_tracks_sim_20260627\\mma_diag.log", "ab") as _df: - _df.write(f"[DIAG] AFTER sort sorted_count={len(sorted_tickets_data) if sorted_tickets_data else 0} type={type(sorted_tickets_data[0]).__name__ if sorted_tickets_data else None}\n".encode()) - except Exception: pass # 3. Create Track and Ticket objects (sorted_tickets_data is list[Ticket]) tickets = [] for t_data in sorted_tickets_data: @@ -4822,24 +4796,12 @@ class AppController: tickets.append(ticket) track_id = f"track_{uuid.uuid5(uuid.NAMESPACE_DNS, f'{self.active_project_path}_{title}').hex[:12]}" track = Track(id=track_id, description=title, tickets=tickets) - try: - with open(b"C:\\projects\\manual_slop_tier2\\tests\\artifacts\\tier2_state\\fix_mma_concurrent_tracks_sim_20260627\\mma_diag.log", "ab") as _df: - _df.write(b"[DIAG] BEFORE save_track_state\n") - except Exception: pass # Initialize track state in the filesystem meta = TrackMetadata(id=track_id, name=title, status="todo", created_at=datetime.now(), updated_at=datetime.now()) state = TrackState(metadata=meta, discussion=[], tasks=tickets) project_manager.save_track_state(track_id, state, self.active_project_root) - try: - with open(b"C:\\projects\\manual_slop_tier2\\tests\\artifacts\\tier2_state\\fix_mma_concurrent_tracks_sim_20260627\\mma_diag.log", "ab") as _df: - _df.write(b"[DIAG] AFTER save_track_state\n") - except Exception: pass # Add to memory and notify UI self.tracks.append({"id": track_id, "title": title, "status": "todo"}) - try: - with open(b"C:\\projects\\manual_slop_tier2\\tests\\artifacts\\tier2_state\\fix_mma_concurrent_tracks_sim_20260627\\mma_diag.log", "ab") as _df: - _df.write(f"[DIAG] _start_track_logic_result self.tracks.append OK title={title!r} track_id={track_id}\n".encode()) - except Exception: pass with self._pending_gui_tasks_lock: self._pending_gui_tasks.append({'action': 'refresh_from_project'}) # 4. Initialize ConductorEngine and run loop