# Plan: Sloppy.py Startup Speedup

**Track:** `startup_speedup_20260606`
**Spec:** [./spec.md](./spec.md)
**Status:** In progress
**Started:** 2026-06-06

---

## Phase 1: Audit + Benchmark + Foundation

- [x] **T1.1** Capture baseline with `scripts/benchmark_imports.py --runs=3 --color=never > docs/reports/startup_baseline_20260606.txt` `[T1.1: 6f9a3af2]`
- [x] **T1.2** Write `scripts/audit_gui2_imports.py` (AST walker): for each `import X` in `src/gui_2.py`, classify as `first-frame` (reachable from `main()` / `render_main_window` etc.) vs `feature-gated` (inside an `if/elif` branch that requires user action). Commit audit results to `docs/reports/startup_audit_20260606.txt`. `[T1.2: 6f9a3af2]`
- [x] **T1.3** Add `src/startup_profiler.py` with `StartupProfiler` class (context manager `phase(name)`). Wire into `AppController.__init__` and `App.__init__` at 8 major init points. (No new test; verify via manual run + diagnostics panel.) `[T1.3: 5a856536]`
- [x] **T1.4** Write `scripts/audit_main_thread_imports.py` (static gate, fails CI). AST-walks the import graph reachable from `sloppy.py`, collects all top-level `import X` / `from X import Y`, compares against an allowlist. Exits non-zero with file:line:module on violation. Allowlist: `sys.stdlib_module_names` + the lean gui_2 skeleton list from `spec.md:2.1` (`imgui_bundle`, `defer`, `src.imgui_scopes`, `src.theme_2` (default theme only), `src.theme_models`, `src.paths`, `src.models`, `src.events`). Walks into if/elif/else and try/except branches (which run at import time); skips function bodies. 9 tests cover all edge cases. `[T1.4: 6f9a3af2]`
- [x] **T1.5** Commit baseline + audit script: `git add . && git commit -m "..." + git note. **DONE**: commits `5a856536` (T1.3 StartupProfiler) and `6f9a3af2` (T1.2+T1.4 audit + baseline). Plan update in progress.

**Phase 1 checkpoint:** Baseline established (docs/reports/startup_baseline_20260606.txt: 3-run median, src.gui_2 is 1770ms). Static gate exists (scripts/audit_main_thread_imports.py: currently fails with 67 violations, the list of work for Phases 3-5). All three import classes (first-frame, feature-gated, background-safe) documented.

---

## Phase 2: Job Pool + Warmup Foundation (the "no new threads" + "no lazy-loading" rules)

Two user constraints, addressed together:
1. **No new `threading.Thread(...)`** per task, per import, per ad-hoc job.
2. **No lazy-loading** in function bodies. Heavy imports are warmed on bg
   threads at startup, not loaded on first use.

The codebase gets ONE shared `ThreadPoolExecutor` on `AppController` named
`_io_pool`, used for warmup AND any future background work.

- [x] **T2.1 (Red)** `tests/test_io_pool.py` (4 tests covering: ThreadPoolExecutor returned, 4 workers, threads named `controller-io-*`, jobs run in parallel via barrier). `[T2.1: 1354679e]`
- [x] **T2.2 (Green)** `src/io_pool.py` — `make_io_pool()` factory: 4-worker `ThreadPoolExecutor` with `thread_name_prefix="controller-io"`. `[T2.2: 1354679e]`
- [x] **T2.3 (Red)** `tests/test_warmup.py` (10 tests covering: one job per module, status, failures, done event, wait, callbacks, fire-immediately, sys.modules, reset, concurrency). `[T2.3: 1354679e]`
- [x] **T2.4 (Green)** `src/warmup.py` — `WarmupManager` class with `submit`, `status`, `is_done`, `wait`, `on_complete`, `reset`. Thread-safe (lock-guarded). Public API on AppController: `warmup_status()`, `is_warmup_done()`, `wait_for_warmup()`, `on_warmup_complete()`. Warmup list always includes `google.genai, anthropic, openai, requests, src.command_palette, src.theme_nerv, src.theme_nerv_fx, src.markdown_table, numpy`; conditionally adds `fastapi, fastapi.security.api_key` when `test_hooks_enabled`. `[T2.4: 1354679e]`
- [x] **T2.5** Wire into `AppController.__init__` (right after locks, before subsystem init). Public delegation methods added. `shutdown()` calls `self._io_pool.shutdown(wait=False)`. All 18 tests pass (io_pool + warmup + existing test_app_controller_*). `[T2.5: 922c5ad9]`
- [x] **T2.6** Plan update + commit: this commit.

**Phase 2 checkpoint:** `AppController` owns a 4-thread named pool. Warmup jobs are submitted in `__init__` and complete in the background. `controller.wait_for_warmup()`, `controller.warmup_status()`, and `controller.on_warmup_complete(cb)` are the public API. Main thread does NOT block waiting for warmup.

**NOTE on current effectiveness:** With the current codebase, the warmup is a no-op for modules already imported at the top of `src/app_controller.py` (fastapi, requests, etc. — already in `sys.modules`). The infrastructure is in place; Phase 3 will remove the top-level imports so the warmup actually does work. The warmup already helps for modules NOT at the top of any main-thread-reachable file (e.g., `src.theme_nerv*` if not yet imported).

---

## Phase 3: Remove top-level heavy imports from `src/ai_client.py` (TDD)

The current `src/ai_client.py` has `from google import genai` etc. at the top,
which puts the main thread in the import chain. Phase 3 removes these and
swaps to `_require_warmed(name)`.

- [x] **T3.1 (Red)** Write `tests/test_ai_client_no_top_level_sdk_imports.py` (9 tests, all currently FAILING). `[T3.1: 16780ec6]`
- [x] **T3.2 (Green)** In `src/ai_client.py` — completed 51c054ec. 5 top-level heavy SDK imports removed (`anthropic`, `google.genai`, `openai`, `google.genai.types`, `requests`). `_require_warmed(name)` helper added at top (returns `sys.modules[name]` with importlib fallback for tests). All 18 functions updated with local lookups at their first executable line. MCP `edit_file` used for `run_discussion_compression` (last one); previous 17 functions edited in prior session. `[T3.2: 51c054ec]`
- [x] **T3.3** Run existing `tests/test_ai_client.py` + `tests/test_tier4_*.py`; fix breakage. 2 tests in `test_tier4_patch_generation.py` adapted: `patch('src.ai_client.types')` -> `patch('src.ai_client._require_warmed', return_value=mock_types)` (the new public mechanism). All 25 tests pass. `[T3.3: 51c054ec]`
- [x] **T3.4** Re-run T3.1 tests, confirm PASS (9/9 green). `[T3.4: 51c054ec]`
- [x] **T3.5** Commit: `refactor(ai_client): remove top-level SDK imports; use _require_warmed` + git note. `[T3.5: 51c054ec]`
- [x] **T3.6** Update `conductor/tracks.md` T3 row with SHA. `[T3.6: 8905c26b]`

**Phase 3 status:** All tasks complete. `import src.ai_client` no longer triggers any heavy SDK import. When run inside an `AppController` whose warmup has completed, `_send_*` functions find the SDKs in `sys.modules` and execute instantly. Cold-start baseline (T9.1) will measure the time saved.

**Phase 3 checkpoint (target):** `import src.ai_client` < 50ms cold. [checkpoint: 056358f2]

---

## Phase 4: Remove top-level FastAPI imports from `src/app_controller.py` (TDD)

**DEVIATION FROM ORIGINAL SPEC**: The original spec/plan stated the fastapi
imports were in `src/api_hooks.py`. After Phase 3 completion, audit revealed
the actual fastapi top-level imports live in `src/app_controller.py` (lines
17 and 21: `from fastapi import FastAPI, Depends, HTTPException` and
`from fastapi.security.api_key import APIKeyHeader`). `src/api_hooks.py` does
not import fastapi at all (it uses stdlib `http.server.ThreadingHTTPServer`).
Phase 4 target is therefore corrected to `src/app_controller.py`.

Same pattern as Phase 3, for the FastAPI imports.

- [x] **T4.1 (Red)** Write `tests/test_app_controller_no_top_level_fastapi.py` (4 tests). Commit pending.
- [x] **T4.2 (Green)** Refactor done in commit 3849d304:
  - Created `src/module_loader.py` (shared home of `_require_warmed`)
  - `src/ai_client.py` re-exports `_require_warmed` for backwards compat
  - `src/app_controller.py`: added `from __future__ import annotations`; removed top-level fastapi imports; added lookups in `create_api()` and 7 `_api_*` helpers (`_api_get_key`, `_api_generate`, `_api_stream`, `_api_confirm_action`, `_api_get_session`, `_api_delete_session`, `_api_get_context`).
  - Import: `from src.module_loader import _require_warmed` (clean separation, not via ai_client)
- [x] **T4.3** No new breakage. Pre-existing `test_generate_endpoint` failure in `test_headless_service.py` is a google.genai circular-import issue (reproduces on stashed pre-Phase-4 state) - not a regression. Documented in commit message.
- [x] **T4.4** T4.1 tests PASS (4/4 green). T3.1 tests still pass (9/9, re-export works).
- [x] **T4.5** Commit: `refactor(app_controller): remove top-level fastapi imports; lift _require_warmed to shared module` (commit 3849d304) + git note.

**Phase 4 checkpoint (target):** `import src.app_controller` does not trigger a fastapi import. The `create_api()` method uses `_require_warmed` to access FastAPI on demand. For non-web / non-`--enable-test-hooks` runs, fastapi is never loaded (saves ~470ms). For `--enable-test-hooks` runs, warmup pre-loads fastapi so the lookup is instant. [checkpoint: 883682c1]

---

## Phase 5: Remove top-level imports for feature-gated GUI modules (TDD per module)

### 5A: Command Palette

- [x] **T5A.1 (Red)** `tests/test_command_palette_no_top_level_import.py` (4 tests, 3 were FAILING). Commit 78d3a1db. `[T5A.1: 78d3a1db]`
- [x] **T5A.2 (Green)** In `src/commands.py`: removed `from src.command_palette import CommandRegistry`. Replaced `registry = CommandRegistry()` with a lazy proxy `_LazyCommandRegistry` that defers instantiation to first attribute access. The 32 `@registry.register` decorators are unchanged (the proxy's `register()` is a no-op that just queues). The real `CommandRegistry` is built via `_get_real_registry()` which calls `_require_warmed("src.command_palette")`. Commit 78d3a1db. `[T5A.2: 78d3a1db]`
- [x] **T5A.3** Run `tests/test_command_palette.py` + `tests/test_command_palette_sim.py`; no fixes needed. Lazy proxy is transparent to consumers. 13/13 + 7/7 pass. `[T5A.3: 78d3a1db]`
- [x] **T5A.4** Commit: `refactor(commands): use lazy registry proxy to defer src.command_palette import` (78d3a1db) + git note. `[T5A.4: 78d3a1db]`

### 5B: NERV Theme

- [x] **T5B.1 (Red)** `tests/test_theme_2_no_top_level_nerv.py` (4 tests, all FAILING). Commit 69d098ba. `[T5B.1: 69d098ba]`
- [x] **T5B.2 (Green)** In `src/theme_2.py`: removed 3 top-level NERV imports (`from src import theme_nerv`, `from src.theme_nerv import DATA_GREEN`, `from src.theme_nerv_fx import CRTFilter, AlertPulsing, StatusFlicker`). Removed 3 module-level FX instantiations (`_crt_filter = CRTFilter()` etc). Added `_require_warmed("src.theme_nerv")` in `apply()` NERV branch and `ai_text_color()`. Added `_require_warmed("src.theme_nerv_fx")` in `render_post_fx()` with FX objects created locally per call. Commit 69d098ba. `[T5B.2: 69d098ba]`
- [x] **T5B.3** Run `tests/test_theme.py` + `tests/test_theme_nerv.py` + `tests/test_theme_nerv_fx.py` + `tests/test_theme_models.py`; no fixes needed. 21/21 pass. `[T5B.3: 69d098ba]`
- [x] **T5B.4** Commit: `refactor(theme_2): remove top-level NERV theme imports; use _require_warmed` (69d098ba) + git note. `[T5B.4: 69d098ba]`

### 5C: Markdown Table

- [x] **T5C.1 (Red)** `tests/test_markdown_helper_no_top_level_table.py` (3 tests, all FAILING). Commit 48c96499. `[T5C.1: 48c96499]`
- [x] **T5C.2 (Green)** In `src/markdown_helper.py`: removed `from src.markdown_table import parse_tables, render_table`. Added `_require_warmed("src.markdown_table")` at the top of `MarkdownRenderer.render()` body; `parse_tables` and `render_table` are now local aliases to the warmed module's functions. Commit 48c96499. `[T5C.2: 48c96499]`
- [x] **T5C.3** Run all `test_markdown_table*.py` + `test_markdown_helper_bullets.py` + `test_markdown_render_robust.py`; no fixes needed. 24/24 pass. `[T5C.3: 48c96499]`
- [x] **T5C.4** Commit: `refactor(markdown_helper): remove top-level src.markdown_table import; use _require_warmed` (48c96499) + git note. `[T5C.4: 48c96499]`

### 5D: GUI module feature-gated imports

- [ ] **T5D.1** Run `scripts/audit_gui2_imports.py` (built in T1.2); collect list of feature-gated imports in `src/gui_2.py`
- [ ] **T5D.2** For each feature-gated import, apply the same TDD pattern (5A-5C). Group into 1-2 atomic commits per logical feature.
- [ ] **T5D.3** Run full GUI test suite; fix.
- [ ] **T5D.4** Commit per feature group

**Phase 5 checkpoint (target):** All heavy imports removed from main-thread-reachable source files. Default-theme / non-palette / non-table path is lean. Warmup pre-loads all of them in the background.

---

## Phase 6: Migrate Ad-hoc Threads to `_io_pool`

The codebase has several ad-hoc `threading.Thread(...)` calls. Per the user
constraint, these should migrate to `controller.submit_io(fn)`.

- [ ] **T6.1** Audit: `grep -rn "threading.Thread(" src/` to find all ad-hoc thread spawns. Document each in `state.toml` (a new `[ad_hoc_threads]` section).
- [ ] **T6.2** For each ad-hoc thread in `src/log_pruner.py`, `src/project_manager.py`, etc., refactor to use `controller.submit_io(fn)` instead. Wrap the callable body in a try/except (the pool's default behavior is to surface exceptions via the Future; preserve existing error logging).
- [ ] **T6.3** Run full test suite; fix.
- [ ] **T6.4** Per-migration commit (or grouped by subsystem if 3+ threads in one file). Final commit: `refactor: migrate ad-hoc threads to AppController._io_pool` + git note.

**Phase 6 checkpoint:** `grep -rn "threading.Thread(" src/` shows ZERO new spawns after this phase (existing project scaffolding threads like `HookServer` and `MMA WorkerPool` are exempt — they're domain-specific).

---

## Phase 7: Warmup Notification (Hook API + GUI)

The user said: *"the app controller should post to test clients or the user
when its threads are warmed up with imports — that way the user knows 'hey
you have the ui first, but now you have all the functionality.'"* This phase
implements the notification surfaces.

### 7A: Hook API endpoints

- [ ] **T7A.1 (Red)** `tests/test_api_hooks_warmup.py`:
  - `test_warmup_status_endpoint`: hit `GET /api/warmup_status`, assert response has `pending`/`completed`/`failed` keys
  - `test_warmup_wait_endpoint`: hit `GET /api/warmup_wait?timeout=10`, assert response includes the completion state
  - Confirm FAIL (endpoints don't exist yet)
- [ ] **T7A.2 (Green)** In `src/api_hooks.py`:
  - Add `GET /api/warmup_status` returning `controller.warmup_status()`
  - Add `GET /api/warmup_wait` accepting `?timeout=N` (default 30s), calling `controller.wait_for_warmup(timeout)` then returning the final status
  - Register `warmup_status` in `_gettable_fields` so the existing Hook API client can fetch it
- [ ] **T7A.3** Run T7A.1 tests; confirm PASS
- [ ] **T7A.4** Commit: `feat(api_hooks): add /api/warmup_status and /api/warmup_wait` + git note

### 7B: GUI status indicator + toast

- [ ] **T7B.1** In `src/gui_2.py` (in the status bar render function), poll `controller.warmup_status()` once per frame. While `pending` is non-empty: show "Warming up... (N/M)" text. When `pending` is empty AND `failed` is empty: show "All imports ready" with a green dot. When `failed` is non-empty: show "Imports: N failed" with a yellow dot.
- [ ] **T7B.2** Register a callback via `controller.on_warmup_complete(cb)` that:
  - On transition to done (with no failures): queue a toast notification "All providers ready (M modules)" via the existing toast system
  - On transition to done (with failures): queue a warning toast "Warmup finished with N failures — see Diagnostics"
- [ ] **T7B.3** Update `docs/guide_gui_2.md` (or wherever status bar is documented) to describe the new indicator
- [ ] **T7B.4** Commit: `feat(gui_2): warmup status indicator + completion toast` + git note

**Phase 7 checkpoint:** Tests can poll `/api/warmup_status` to know when the system is fully ready. The GUI shows progress during startup and a toast when complete.

---

## Phase 8: Enforcement (Runtime Audit Hook)

The static gate (T1.4) catches known imports at audit time. This phase adds
empirical enforcement: a test that spawns `sloppy.py` and verifies NO heavy
import happens on the main thread at runtime.

- [ ] **T8.1 (Red)** `tests/test_main_thread_purity.py`:
  - `test_headless_startup_no_heavy_imports_on_main`: spawn `uv run python sloppy.py --headless --enable-test-hooks` with a `sitecustomize.py` shim that installs `sys.addaudithook` to log every `import` event with the calling thread. The hook writes to a temp file as JSON-L.
  - Wait for headless server ready (5s timeout via `ApiHookClient`).
  - Read the audit log. Assert: no event with `thread_name == "MainThread"` for any module in the heavy denylist (`google.genai`, `anthropic`, `openai`, `fastapi`, `requests`, `numpy`, `tkinter`, `psutil`, `pydantic`, `tree_sitter_*`, `src.command_palette`, `src.theme_nerv`, `src.theme_nerv_fx`, `src.markdown_table`).
  - Kill subprocess. Confirm FAIL (current state imports these on main).
- [ ] **T8.2** Once Phase 3-5 land and the static gate passes, this test should start passing. If it doesn't, debug and add more top-level import removals.
- [ ] **T8.3** Wire `test_main_thread_purity.py` into CI as a gating test (it'll be slow, ~10s, so mark with `@pytest.mark.slow` and only run in batched CI).
- [ ] **T8.4** Commit: `test: empirical main-thread purity check via sys.audit hook` + git note

**Phase 8 checkpoint:** CI fails if a future commit re-introduces a heavy main-thread import.

---

## Phase 9: Verify + Phase Checkpoint

- [ ] **T9.1** Re-run `scripts/benchmark_imports.py --runs=3`. Save to `docs/startup_after_20260606.txt`. Diff against T1.1 baseline; confirm:
  - `import src.ai_client` < 50ms
  - `import src.gui_2` < 500ms
  - `import src.app_controller` < 300ms (includes `_io_pool` creation; should still be < 300ms)
- [ ] **T9.2** Re-run `scripts/audit_main_thread_imports.py` (T1.4). Confirm exit 0. No violations.
- [ ] **T9.3** Run `tests/test_warmup_mechanism.py` (T2.3); confirm warmup completes and notifications fire
- [ ] **T9.4** Run `live_gui` test batch (per `conductor/workflow.md:147-150`: max 4 test files per batch, long timeout):
  - `uv run pytest tests/test_live_gui_*.py --timeout=60 -v` in batches
  - Confirm `wait_for_server(timeout=15)` does not time out
  - Optionally: tests can call `controller.wait_for_warmup()` before exercising functionality that depends on warmed modules
- [ ] **T9.5** Manual smoke:
  - `uv run sloppy.py` (normal mode): time-to-first-frame, observe "Warming up... (N/M)" status, then "All imports ready" toast
  - `uv run sloppy.py --enable-test-hooks` (test mode): same observations, plus `/api/warmup_status` returns `completed`
  - `uv run sloppy.py --headless` (headless): time-to-server-ready
  - Verify a user action that switches provider (or other warmup-dependent operation) is INSTANT, not 1s-delayed
- [ ] **T9.6** Phase checkpoint commit: `conductor(checkpoint): Phase 9 complete - sloppy.py startup speedup track` + git note with full verification report
- [ ] **T9.7** Update `conductor/tracks.md`: mark track complete, link to archived folder

**Phase 9 checkpoint:** All verification criteria in `spec.md:6` met. User can switch providers with zero perceptible lag because warmup already loaded the SDK.

---

## Definition of Done

- [ ] All Phase 1-9 tasks checked
- [ ] All tests pass (273+ existing + new TDD tests including `test_main_thread_purity` and `test_warmup_mechanism`)
- [ ] `uv run ruff check .` and `uv run mypy --explicit-package-bases .` clean (per `mma-tier2-tech-lead` skill)
- [ ] `uv run python scripts/audit_main_thread_imports.py` exits 0
- [ ] `docs/startup_baseline_20260606.txt` and `docs/startup_after_20260606.txt` archived
- [ ] Phase 9 git note contains: baseline diff, audit script result, runtime audit hook result, full test batch results, manual smoke timings, file inventory
- [ ] Track moved to `conductor/tracks/archive/`
- [ ] **NO new `threading.Thread(...)` calls in `src/`** (verified by `grep -rn "threading.Thread(" src/`)
- [ ] **NO `import X` statements in function bodies for heavy modules** — verified by `grep -rn "^\s*import \(google\|anthropic\|openai\|fastapi\|src\.command_palette\|src\.theme_nerv\|src\.markdown_table\)" src/`
- [ ] **Warmup completion notification works** — GUI shows toast, Hook API returns `completed`, `controller.is_warmup_done()` returns True within 10s of startup
- [ ] **User action latency is zero for warmup-dependent operations** — manual smoke test switching providers / opening palette / rendering NERV is instant

---

## Notes for Tier 3 Workers

- **Always use 1-space indentation for Python code.** Confirm via `uv run python -c "import ast; ..."` AST check if you do any class-body reorganization (the "Indentation-Driven Class Method Visibility" pitfall in `conductor/workflow.md`).
- **Test fixtures**: `isolate_workspace`, `reset_paths`, `reset_ai_client`, `vlogger`, `kill_process_tree`, `mock_app`, `live_gui` — see `docs/guide_testing.md`.
- **Subprocess tests for module-level imports**: spawn `uv run python -c "..."` and inspect `sys.modules` after the import. Pattern:
  ```python
  result = subprocess.run(
      [sys.executable, "-c", "import sys; import src.ai_client; import json; print(json.dumps(sorted(sys.modules.keys())))"],
      capture_output=True, text=True
  )
  assert 'google.genai' not in result.stdout
  ```
- **For new background work**: use `controller.submit_io(fn, *args)`, NOT `threading.Thread(target=fn).start()`. The user constraint is "no new threads."
- **Atomic commits per task.** No batching. If a task touches 3 files, commit all 3 in one commit but the commit message describes the task.
- **The `_io_pool` is a daemon executor by default in Python 3.9+; non-daemon workers in 3.8.** Check `pyproject.toml` for `requires-python`. Either way, the pool is shut down on `AppController.shutdown()`.

---

## Cross-References

- Spec: [./spec.md](./spec.md)
- Original backlog entry: `conductor/tracks.md:152`
- Benchmark tool: `scripts/benchmark_imports.py`
- Lazy pattern templates: `src/app_controller.py:241-271` (RAG + MMA)
- Threading constraints: `docs/guide_architecture.md:43-67`
- Architectural Invariant: `spec.md:2.1`
- Job pool spec: `spec.md:2.2 Layer 2`
- Hot reload constraints: `docs/guide_hot_reload.md:295-312`
