ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-04 14:48:47 +00:00
Code Issues Packages Projects Releases Wiki Activity
15,022 Commits 1 Branch 80 Tags
e5a4f3bcae39f467c3f613874b14356a90efe11d
Commit Graph
15022 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Feoramund 7526549e51 Disable usage of AddressSanitizer (pt. 2) 2025-06-15 15:34:18 -04:00
Feoramund 5e929b596d Merge branch 'master' into fix-2694 2025-06-15 15:30:26 -04:00
Feoramund efba9a1fb7 Disable usage of AddressSanitizer pending a per-allocator review 
It has been discovered that AddressSanitizer does not keep a 1:1 mapping
of which bytes are poisoned and which are not. This can cause issues for
allocations less than 8 bytes and where addresses straddle 8-byte
boundaries.

See the following link for more information:

https://github.com/google/sanitizers/wiki/AddressSanitizerAlgorithm#mapping
 2025-06-15 15:06:28 -04:00
Feoramund 0b2cf9a4ca Add a tiny sanity test for core:mem allocators 2025-06-15 14:29:30 -04:00
Feoramund 134c39b58b mem: Standardize panic messages 2025-06-15 12:34:16 -04:00
Feoramund e4258b151e mem: Review all documentation comments 2025-06-15 12:34:16 -04:00
Feoramund 7524762620 mem: Poison memory for Buddy_Allocator 2025-06-15 12:34:16 -04:00
Feoramund 7e77bd425f mem: Guard against size 0 in dynamic_arena_resize_* 2025-06-15 12:34:16 -04:00
Feoramund 78a10b462f mem: Poison memory for Dynamic_Arena 2025-06-15 12:34:16 -04:00
Feoramund de3c322899 mem: Make dynamic_arena_alloc not private 
None of the other `*_alloc` procs are private, and this proc is even
referenced in public documentation comments.
 2025-06-15 12:34:16 -04:00
Feoramund 652c0c997d mem: Remove bogus comments 
There is no `dynamic_arena_free`; the mode is not implemented
 2025-06-15 12:34:15 -04:00
Feoramund c1e3171178 mem: Remove comment about calling panic 
The behavior is codified in the comment as returning `Invalid_Pointer`.
 2025-06-15 12:34:15 -04:00
Feoramund aaeae8bc7d mem: Remove trailing whitespace 2025-06-15 12:34:15 -04:00
Feoramund 47a54dd11a mem: Panic when passing invalid pointers to small stack free/resize 
This is consistent with `Stack_Allocator`.
 2025-06-15 12:34:15 -04:00
Feoramund d7e98ba82a Add test for issue #2694 2025-06-15 12:34:15 -04:00
Feoramund 3261896790 mem: Correct wrong error message 2025-06-15 12:34:15 -04:00
Feoramund aa41a77fc4 mem: Check if alignment matches on Small_Stack resize 2025-06-15 12:34:15 -04:00
Feoramund 3a02918efc mem: Make small_stack_resize* free if size is 0 2025-06-15 12:34:15 -04:00
Feoramund a4771ce1b5 mem: Clarify what happens when you free out-of-order in a Small_Stack 2025-06-15 12:34:15 -04:00
Feoramund 21a17c1ae6 mem: Replace auto_cast 2025-06-15 12:34:15 -04:00
Feoramund 8f68c46467 mem: Don't unpoison the header of a Small_Stack allocation 2025-06-15 12:34:15 -04:00
PePerRoNii c08d9c50c8 Changed TCP_Recv_Err to Socket_Info_Err and tested on darwin_arm64 2025-06-15 12:14:59 +07:00
PePerRoNii 42aa8ac383 Implemented _socket_info_error on peer_endpoint and bound_endpoint 2025-06-15 11:17:49 +07:00
PePerRoNii f49bf1abd2 added Socket_Info_Errors Enum 2025-06-15 10:26:06 +07:00
Feoramund 5798151a0e mem: Poison unused memory more thoroughly 2025-06-14 13:21:15 -04:00
Feoramund ae96b276c1 mem: Check if alignment matches on Stack_Allocator resize 2025-06-14 13:21:15 -04:00
Feoramund 837d8cf72c mem: Actually resize when resizing for Stack_Allocator 
Changed the check from `bytes` to `err` for safety's sake, too.

This will prevent the potential bug of allocating non-zero memory, then
doing a zeroed resize, which will result in having garbage data in the
initial half.
 2025-06-14 13:21:14 -04:00
Feoramund f701aeffd5 mem: Correct wrong error message 2025-06-14 13:21:14 -04:00
Feoramund 7580dc2dd0 mem: Remove pointless check in Scratch_Allocator 
The backup allocator is set at `init` which happens even if `Scratch` is
nil at the head of `scratch_alloc_bytes_non_zeroed`.
 2025-06-14 13:21:14 -04:00
Feoramund c4f6e973d9 mem: Don't change Scratch_Allocator's backup allocator 
The backup allocator is set at `init` and must stay the same for the
lifetime of the Scratch allocator, as this allocator is used to free all
`leaked_allocations`. Changing it could lead to a situation where the
wrong allocator is used to free a leaked allocation.
 2025-06-14 13:21:14 -04:00
Feoramund 62b0f71768 mem: Fix comment typo 2025-06-14 13:21:14 -04:00
Feoramund 890245c229 mem: Don't unpoison the header of a Stack allocation 2025-06-14 13:21:14 -04:00
Feoramund 79e5ddaa26 mem: Make stack_resize* free if size is 0 
This will cause an error if the memory being resized was not the last
allocation, as should be expected according to the description that this
"acts just like stack_free."
 2025-06-14 13:21:14 -04:00
Feoramund 179a8559f6 mem: Add guards against buggy allocators overlapping allocations 2025-06-14 13:21:14 -04:00
Feoramund f627b55cf5 mem: Fix several issues in Scratch_Allocator 
1. The size was being adjusted for the alignment which does not make any
   sense without the context of the base pointer. Now we just add the
   `alignment - 1` to the size if needed then adjust the pointer.

2. The root pointer of the last allocation is now stored in order to
   make the free operation more useful (and to cover the right memory
   region for ASan).

3. Resizing now only works on the last allocation instead of any address
   in a valid range, which resulted in overwriting allocations that had
   just been made.

4. `old_memory` is now re-poisoned entirely before the resized range is
   returned with the new range unpoisoned. This will guarantee that
   there are no unpoisoned gaps.

Fixes #2694
 2025-06-14 12:35:16 -04:00
Jeroen van RijnandGitHub 771c1c4332 Merge pull request #5334 from Kelimion/types-checks 
Add additional nullptr checks in types.cpp
 2025-06-14 01:22:15 +02:00
Jeroen van Rijn cc08dca53d Add additional nullptr checks in types.cpp 
Ran into a bunch of nullptr problems while reviving an 8-year old Odin problem.
 2025-06-14 01:13:36 +02:00
Laytan Laats 144daf6fff add macOS Tahoe to odin report and core:sys/info 2025-06-14 00:27:37 +02:00
LaytanandGitHub aa0cffb412 Merge pull request #5328 from laytan/compat-allocator-improvements 
mem: compat allocator improvements
 2025-06-13 19:41:58 +02:00
Jeroen van RijnandGitHub f03484e352 Merge pull request #5332 from Kelimion/replace_environment_variables 
Replace core:posix usage in core:os/os2
 2025-06-13 18:15:31 +02:00
Feoramund 61f9fb7232 runtime: Remove unneeded max(0, ...) 
`len` never returns negative numbers, so this was an overcautious
expression.
 2025-06-13 12:09:10 -04:00
Jeroen van Rijn 84eaddbd47 WASI 2025-06-13 18:08:35 +02:00
Jeroen van Rijn 8c8406cc4d stub out get_env for js 2025-06-13 18:00:30 +02:00
Jeroen van Rijn 3862555153 Replace core:posix usage in core:os/os2 2025-06-13 17:49:05 +02:00
Jeroen van Rijn fe9f74f7a2 Disable PR comments 2025-06-13 07:24:03 +02:00
LaytanandGitHub fc7fc4d5cd Merge pull request #5289 from JackMordaunt/jfm-sync_chan_refactor 
Jfm sync chan refactor
 2025-06-12 21:51:34 +02:00
Jack Mordaunt 3c3fd6e580 tests/core/sync/chan: move global state into test 
While this state is not actually needed by more than one test, we can
just make it a static variable.
 2025-06-12 16:14:52 -03:00
Jack Mordaunt c1cd525d9d core/sync/chan.select_raw: call try_select_raw with deprecation warning 
Eventually select_raw should be a blocking select operation, but for now
we need to migrate people away.
 2025-06-12 16:14:52 -03:00
Jack Mordaunt 96b91849a9 core/sync/chan.try_select_raw: fix doc comment typo 
Signed-off-by: Jack Mordaunt <jackmordaunt.dev@gmail.com>
 2025-06-12 16:14:52 -03:00
Jack Mordaunt 4d7c182f7d tests/core/sync/chan: test harness for chan.try_select_raw 
This test harness ensures consistent non-blocking semantics and
validates that we have solved the toctou condition.

The __global_context_for_test is a bit of a hack to fuse together the
test supplied proc and the executing logic in packaage chan.
 2025-06-12 16:14:52 -03:00