ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-06 07:38:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove extra checks

Browse Source
This commit is contained in:
gingerBill
2025-09-19 16:44:57 +01:00
parent 9b8771b475
commit f36ade8c64
1 changed files with 2 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/llvm_backend_general.cpp
+2 -13
View File
@@ -3082,12 +3082,9 @@ gb_internal lbValue lb_find_procedure_value_from_entity(lbModule *m, Entity *e)
if (found == nullptr) { if (found == nullptr) {
// THIS IS THE RACE CONDITION // THIS IS THE RACE CONDITION
lbProcedure *missing_proc_in_other_module = lb_create_procedure(other_module, e, false); lbProcedure *missing_proc_in_other_module = lb_create_procedure(other_module, e, false);
if (!missing_proc_in_other_module->is_done.load(std::memory_order_relaxed)) { mpsc_enqueue(&other_module->missing_procedures_to_check, missing_proc_in_other_module);
mpsc_enqueue(&other_module->missing_procedures_to_check, missing_proc_in_other_module);
}
} }
} else { } else {
GB_PANIC("missing procedure: %.*s", LIT(missing_proc->name));
mpsc_enqueue(&m->missing_procedures_to_check, missing_proc); mpsc_enqueue(&m->missing_procedures_to_check, missing_proc);
} }
@@ -3133,15 +3130,9 @@ gb_internal lbValue lb_generate_anonymous_proc_lit(lbModule *m, String const &pr
token.string = name; token.string = name;
Entity *e = alloc_entity_procedure(nullptr, token, type, pl->tags); Entity *e = alloc_entity_procedure(nullptr, token, type, pl->tags);
e->file = expr->file(); e->file = expr->file();
#if 0
e->pkg = e->file->pkg;
e->scope = e->file->scope; e->scope = e->file->scope;
lbModule *target_module = lb_module_of_entity(gen, e, m);
#else
lbModule *target_module = m; lbModule *target_module = m;
#endif
GB_ASSERT(target_module != nullptr); GB_ASSERT(target_module != nullptr);
// NOTE(bill): this is to prevent a race condition since these procedure literals can be created anywhere at any time // NOTE(bill): this is to prevent a race condition since these procedure literals can be created anywhere at any time
@@ -3160,9 +3151,7 @@ gb_internal lbValue lb_generate_anonymous_proc_lit(lbModule *m, String const &pr
rw_mutex_shared_unlock(&target_module->values_mutex); rw_mutex_shared_unlock(&target_module->values_mutex);
if (found == nullptr) { if (found == nullptr) {
lbProcedure *missing_proc_in_target_module = lb_create_procedure(target_module, e, false); lbProcedure *missing_proc_in_target_module = lb_create_procedure(target_module, e, false);
if (!missing_proc_in_target_module->is_done.load(std::memory_order_relaxed)) { mpsc_enqueue(&target_module->missing_procedures_to_check, missing_proc_in_target_module);
mpsc_enqueue(&target_module->missing_procedures_to_check, missing_proc_in_target_module);
}
} }
lbProcedure *p = lb_create_procedure(m, e, true); lbProcedure *p = lb_create_procedure(m, e, true);