ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-06 15:48:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix race condition in error_va

Browse Source 
If the error count exceeded `MAX_ERROR_COLLECTOR_COUNT`, multiple
threads could print and exit simultaneously, causing a segfault.

This change moves the mutex lock back before the conditional.
This commit is contained in:
Feoramund
2024-04-28 14:03:11 -04:00
parent a37826e646
commit f1c13d6bd8
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/error.cpp
+1 -1
View File
@@ -376,11 +376,11 @@ gb_internal void error_out_coloured(char const *str, TerminalStyle style, Termin
gb_internal void error_va(TokenPos const &pos, TokenPos end, char const *fmt, va_list va) { gb_internal void error_va(TokenPos const &pos, TokenPos end, char const *fmt, va_list va) {
global_error_collector.count.fetch_add(1); global_error_collector.count.fetch_add(1);
mutex_lock(&global_error_collector.mutex);
if (global_error_collector.count > MAX_ERROR_COLLECTOR_COUNT()) { if (global_error_collector.count > MAX_ERROR_COLLECTOR_COUNT()) {
print_all_errors(); print_all_errors();
gb_exit(1); gb_exit(1);
} }
mutex_lock(&global_error_collector.mutex);
push_error_value(pos, ErrorValue_Error); push_error_value(pos, ErrorValue_Error);
// NOTE(bill): Duplicate error, skip it // NOTE(bill): Duplicate error, skip it