ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-06 07:38:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Minor fix to internal using logic with LLVM causing a compiler bug

Browse Source
This commit is contained in:
gingerBill
2023-06-06 10:58:36 +01:00
parent 788f3c22bf
commit efb7fd919b
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/llvm_backend_const.cpp
+9 -4
View File
@@ -107,7 +107,11 @@ gb_internal LLVMValueRef llvm_const_cast(LLVMValueRef val, LLVMTypeRef dst) {
case LLVMPointerTypeKind: case LLVMPointerTypeKind:
return LLVMConstPointerCast(val, dst); return LLVMConstPointerCast(val, dst);
case LLVMStructTypeKind: case LLVMStructTypeKind:
return LLVMConstBitCast(val, dst); // GB_PANIC("%s -> %s", LLVMPrintValueToString(val), LLVMPrintTypeToString(dst));
// NOTE(bill): It's not possible to do a bit cast on a struct, why was this code even here in the first place?
// It seems mostly to exist to get around the "anonymous -> named" struct assignments
// return LLVMConstBitCast(val, dst);
return val;
default: default:
GB_PANIC("Unhandled const cast %s to %s", LLVMPrintTypeToString(src), LLVMPrintTypeToString(dst)); GB_PANIC("Unhandled const cast %s to %s", LLVMPrintTypeToString(src), LLVMPrintTypeToString(dst));
} }
@@ -1036,9 +1040,10 @@ gb_internal lbValue lb_const_value(lbModule *m, Type *type, ExactValue value, bo
} }
cv_type = cvt->Struct.fields[index]->type; cv_type = cvt->Struct.fields[index]->type;
if (is_type_struct(cv_type)) { if (is_type_struct(cvt)) {
auto cv_field_remapping = lb_get_struct_remapping(m, cv_type); auto cv_field_remapping = lb_get_struct_remapping(m, cvt);
idx_list[j-1] = cast(unsigned)cv_field_remapping[index]; unsigned remapped_index = cast(unsigned)cv_field_remapping[index];
idx_list[j-1] = remapped_index;
} else { } else {
idx_list[j-1] = cast(unsigned)index; idx_list[j-1] = cast(unsigned)index;
} }