ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-05 15:18:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make the utf16 conversion procedures in core:sys/windows safer by checking for memory leaks

Browse Source
This commit is contained in:
gingerBill
2022-05-12 13:17:58 +01:00
parent bb4f108487
commit eef44b11f3
17 changed files with 105 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/sys/win32/tests/general.odin
+23 -23
View File
@@ -1,41 +1,41 @@
package win32_tests
import "core:sys/win32"
import win32 "core:sys/windows"
import "core:testing"
utf16_to_utf8 :: proc(t: ^testing.T, str: []u16, comparison: string, expected_result: bool, loc := #caller_location) {
result := win32.utf16_to_utf8(str[:]);
testing.expect(t, (result == comparison) == expected_result, "Incorrect utf16_to_utf8 conversion", loc);
result, _ := win32.utf16_to_utf8(str[:])
testing.expect(t, (result == comparison) == expected_result, "Incorrect utf16_to_utf8 conversion", loc)
}
wstring_to_utf8 :: proc(t: ^testing.T, str: []u16, comparison: string, expected_result: bool, loc := #caller_location) {
result := win32.wstring_to_utf8(nil if len(str) == 0 else cast(win32.Wstring)&str[0], -1);
testing.expect(t, (result == comparison) == expected_result, "Incorrect wstring_to_utf8 conversion", loc);
result, _ := win32.wstring_to_utf8(nil if len(str) == 0 else cast(win32.Wstring)&str[0], -1)
testing.expect(t, (result == comparison) == expected_result, "Incorrect wstring_to_utf8 conversion", loc)
}
@test
test_utf :: proc(t: ^testing.T) {
utf16_to_utf8(t, []u16{}, "", true);
utf16_to_utf8(t, []u16{0}, "", true);
utf16_to_utf8(t, []u16{0, 't', 'e', 's', 't'}, "", true);
utf16_to_utf8(t, []u16{0, 't', 'e', 's', 't', 0}, "", true);
utf16_to_utf8(t, []u16{'t', 'e', 's', 't'}, "test", true);
utf16_to_utf8(t, []u16{'t', 'e', 's', 't', 0}, "test", true);
utf16_to_utf8(t, []u16{'t', 'e', 0, 's', 't'}, "te", true);
utf16_to_utf8(t, []u16{'t', 'e', 0, 's', 't', 0}, "te", true);
utf16_to_utf8(t, []u16{}, "", true)
utf16_to_utf8(t, []u16{0}, "", true)
utf16_to_utf8(t, []u16{0, 't', 'e', 's', 't'}, "", true)
utf16_to_utf8(t, []u16{0, 't', 'e', 's', 't', 0}, "", true)
utf16_to_utf8(t, []u16{'t', 'e', 's', 't'}, "test", true)
utf16_to_utf8(t, []u16{'t', 'e', 's', 't', 0}, "test", true)
utf16_to_utf8(t, []u16{'t', 'e', 0, 's', 't'}, "te", true)
utf16_to_utf8(t, []u16{'t', 'e', 0, 's', 't', 0}, "te", true)
wstring_to_utf8(t, []u16{}, "", true);
wstring_to_utf8(t, []u16{0}, "", true);
wstring_to_utf8(t, []u16{0, 't', 'e', 's', 't'}, "", true);
wstring_to_utf8(t, []u16{0, 't', 'e', 's', 't', 0}, "", true);
wstring_to_utf8(t, []u16{'t', 'e', 's', 't', 0}, "test", true);
wstring_to_utf8(t, []u16{'t', 'e', 0, 's', 't'}, "te", true);
wstring_to_utf8(t, []u16{'t', 'e', 0, 's', 't', 0}, "te", true);
wstring_to_utf8(t, []u16{}, "", true)
wstring_to_utf8(t, []u16{0}, "", true)
wstring_to_utf8(t, []u16{0, 't', 'e', 's', 't'}, "", true)
wstring_to_utf8(t, []u16{0, 't', 'e', 's', 't', 0}, "", true)
wstring_to_utf8(t, []u16{'t', 'e', 's', 't', 0}, "test", true)
wstring_to_utf8(t, []u16{'t', 'e', 0, 's', 't'}, "te", true)
wstring_to_utf8(t, []u16{'t', 'e', 0, 's', 't', 0}, "te", true)
// WARNING: Passing a non-zero-terminated string to wstring_to_utf8 is dangerous,
// as it will go out of bounds looking for a zero.
// It will "fail" or "succeed" by having a zero just after the end of the input string or not.
wstring_to_utf8(t, []u16{'t', 'e', 's', 't'}, "test", false);
wstring_to_utf8(t, []u16{'t', 'e', 's', 't', 0}[:4], "test", true);
wstring_to_utf8(t, []u16{'t', 'e', 's', 't', 'q'}[:4], "test", false);
wstring_to_utf8(t, []u16{'t', 'e', 's', 't'}, "test", false)
wstring_to_utf8(t, []u16{'t', 'e', 's', 't', 0}[:4], "test", true)
wstring_to_utf8(t, []u16{'t', 'e', 's', 't', 'q'}[:4], "test", false)
}