[os2/process]: Don't quote arguments unless needed

This commit is contained in:
flysand7
2024-09-19 22:38:20 +11:00
parent 7491b3c332
commit ee02d04a9b
+23 -1
View File
@@ -638,6 +638,19 @@ _parse_command_line :: proc(cmd_line_w: [^]u16, allocator: runtime.Allocator) ->
return return
} }
@(private)
QUOTED_CHARS :: "()[]{}^=;!'+,`~\" "
@(private)
_char_needs_escape :: proc(ch: u8) -> bool {
for r in transmute([]byte) string(QUOTED_CHARS) {
if ch == r {
return true
}
}
return false
}
_build_command_line :: proc(command: []string, allocator: runtime.Allocator) -> string { _build_command_line :: proc(command: []string, allocator: runtime.Allocator) -> string {
_write_byte_n_times :: #force_inline proc(builder: ^strings.Builder, b: byte, n: int) { _write_byte_n_times :: #force_inline proc(builder: ^strings.Builder, b: byte, n: int) {
for _ in 0 ..< n { for _ in 0 ..< n {
@@ -650,6 +663,14 @@ _build_command_line :: proc(command: []string, allocator: runtime.Allocator) ->
strings.write_byte(&builder, ' ') strings.write_byte(&builder, ' ')
} }
j := 0 j := 0
arg_needs_quoting := false
// Note(flysand): From documentation of `cmd.exe`, run "cmd /?"
if strings.contains_any(arg, QUOTED_CHARS) {
arg_needs_quoting = true
}
if !arg_needs_quoting {
strings.write_string(&builder, arg)
} else {
strings.write_byte(&builder, '"') strings.write_byte(&builder, '"')
for j < len(arg) { for j < len(arg) {
backslashes := 0 backslashes := 0
@@ -662,7 +683,7 @@ _build_command_line :: proc(command: []string, allocator: runtime.Allocator) ->
break break
} else if arg[j] == '"' { } else if arg[j] == '"' {
_write_byte_n_times(&builder, '\\', 2*backslashes+1) _write_byte_n_times(&builder, '\\', 2*backslashes+1)
strings.write_byte(&builder, '"') strings.write_byte(&builder, arg[j])
} else { } else {
_write_byte_n_times(&builder, '\\', backslashes) _write_byte_n_times(&builder, '\\', backslashes)
strings.write_byte(&builder, arg[j]) strings.write_byte(&builder, arg[j])
@@ -671,6 +692,7 @@ _build_command_line :: proc(command: []string, allocator: runtime.Allocator) ->
} }
strings.write_byte(&builder, '"') strings.write_byte(&builder, '"')
} }
}
return strings.to_string(builder) return strings.to_string(builder)
} }