ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-06 15:48:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

bigint: remove unnecessary boundary checks.

Browse Source
This commit is contained in:
Jeroen van Rijn
2021-08-11 20:59:50 +02:00
parent d7ae611f76
commit e600e5947b
1 changed files with 2 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/math/bigint/radix.odin
+2 -24
View File
@@ -145,29 +145,20 @@ itoa_raw :: proc(a: ^Int, radix: i8, buffer: []u8, size := int(-1), zero_termina
Fast path for when `Int` == 0 or the entire `Int` fits in a single radix digit. Fast path for when `Int` == 0 or the entire `Int` fits in a single radix digit.
*/ */
if is_zero(a) || (a.used == 1 && a.digit[0] < DIGIT(radix)) { if is_zero(a) || (a.used == 1 && a.digit[0] < DIGIT(radix)) {
needed := 2 if is_neg(a) else 1;
needed += 1 if zero_terminate else 0;
if available < needed {
return 0, .Buffer_Overflow;
}
if zero_terminate { if zero_terminate {
available -= 1; available -= 1;
buffer[available] = 0; buffer[available] = 0;
written += 1;
} }
available -= 1; available -= 1;
buffer[available] = RADIX_TABLE[a.digit[0]]; buffer[available] = RADIX_TABLE[a.digit[0]];
written += 1;
if is_neg(a) { if is_neg(a) {
available -= 1; available -= 1;
buffer[available] = '-'; buffer[available] = '-';
written += 1;
} }
return written, .OK; return len(buffer) - available, .OK;
} }
/* /*
@@ -175,36 +166,23 @@ itoa_raw :: proc(a: ^Int, radix: i8, buffer: []u8, size := int(-1), zero_termina
*/ */
if a.used == 1 || a.used == 2 { if a.used == 1 || a.used == 2 {
if zero_terminate { if zero_terminate {
if available == 0 {
return written, .Buffer_Overflow;
}
available -= 1; available -= 1;
buffer[available] = 0; buffer[available] = 0;
written += 1;
} }
val := _WORD(a.digit[1]) << _DIGIT_BITS + _WORD(a.digit[0]); val := _WORD(a.digit[1]) << _DIGIT_BITS + _WORD(a.digit[0]);
for val > 0 { for val > 0 {
if available == 0 {
return written, .Buffer_Overflow;
}
q := val / _WORD(radix); q := val / _WORD(radix);
available -= 1; available -= 1;
buffer[available] = RADIX_TABLE[val - (q * _WORD(radix))]; buffer[available] = RADIX_TABLE[val - (q * _WORD(radix))];
written += 1;
val = q; val = q;
} }
if is_neg(a) { if is_neg(a) {
if available == 0 {
return written, .Buffer_Overflow;
}
available -= 1; available -= 1;
buffer[available] = '-'; buffer[available] = '-';
written += 1;
} }
return written, .OK; return len(buffer) - available, .OK;
} }
/* /*