ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-06 15:48:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make types like bit_set[$T] have their upper and lower bits overwritten by upper/lower from the source types when checking if polymorphic type is assignable. This fixes an issue where an i8 was always generated for bit_sets with generic elements, because it couldn't figure out upper/lower when check_bit_set_type was run. Fixes #2860

Browse Source
This commit is contained in:
Karl Zylinski
2024-06-30 20:36:51 +02:00
parent 52aa7085e4
commit e0face1ac8
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/check_expr.cpp
+10
View File
@@ -1435,6 +1435,16 @@ gb_internal bool is_polymorphic_type_assignable(CheckerContext *c, Type *poly, T
if (!is_polymorphic_type_assignable(c, poly->BitSet.elem, source->BitSet.elem, true, modify_type)) { if (!is_polymorphic_type_assignable(c, poly->BitSet.elem, source->BitSet.elem, true, modify_type)) {
return false; return false;
} }
// For generic types like bit_set[$T] the upper and lower of the poly type will be zeroes since
// it could not figure that stuff out when the poly type was created.
if (poly->BitSet.upper == 0 && modify_type) {
poly->BitSet.upper = source->BitSet.upper;
}
if (poly->BitSet.lower == 0 && modify_type) {
poly->BitSet.lower = source->BitSet.lower;
}
if (poly->BitSet.underlying == nullptr) { if (poly->BitSet.underlying == nullptr) {
if (modify_type) { if (modify_type) {
poly->BitSet.underlying = source->BitSet.underlying; poly->BitSet.underlying = source->BitSet.underlying;