ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-06 07:38:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove safe_heap_allocator from test runner

Browse Source 
I was under the impression that the default `context.allocator` was not
thread-safe, but I've been told that this is not the case.
This commit is contained in:
Feoramund
2024-06-02 14:47:06 -04:00
parent eadfbb1318
commit dffc3af86c
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/testing/runner.odin
+3 -9
View File
@@ -277,10 +277,6 @@ runner :: proc(internal_tests: []Internal_Test) -> bool {
fmt.assertf(alloc_error == nil, "Error allocating memory for task data slots: %v", alloc_error) fmt.assertf(alloc_error == nil, "Error allocating memory for task data slots: %v", alloc_error)
defer delete(task_data_slots) defer delete(task_data_slots)
safe_heap: mem.Mutex_Allocator
mem.mutex_allocator_init(&safe_heap, context.allocator)
safe_heap_allocator := mem.mutex_allocator(&safe_heap)
// Tests rotate through these allocators as they finish. // Tests rotate through these allocators as they finish.
task_allocators: []mem.Rollback_Stack = --- task_allocators: []mem.Rollback_Stack = ---
task_allocators, alloc_error = make([]mem.Rollback_Stack, thread_count) task_allocators, alloc_error = make([]mem.Rollback_Stack, thread_count)
@@ -295,7 +291,7 @@ runner :: proc(internal_tests: []Internal_Test) -> bool {
} }
#no_bounds_check for i in 0 ..< thread_count { #no_bounds_check for i in 0 ..< thread_count {
alloc_error = mem.rollback_stack_init(&task_allocators[i], PER_THREAD_MEMORY, block_allocator = safe_heap_allocator) alloc_error = mem.rollback_stack_init(&task_allocators[i], PER_THREAD_MEMORY)
fmt.assertf(alloc_error == nil, "Error allocating memory for task allocator #%i: %v", i, alloc_error) fmt.assertf(alloc_error == nil, "Error allocating memory for task allocator #%i: %v", i, alloc_error)
when TRACKING_MEMORY { when TRACKING_MEMORY {
mem.tracking_allocator_init(&task_memory_trackers[i], mem.rollback_stack_allocator(&task_allocators[i])) mem.tracking_allocator_init(&task_memory_trackers[i], mem.rollback_stack_allocator(&task_allocators[i]))
@@ -339,11 +335,9 @@ runner :: proc(internal_tests: []Internal_Test) -> bool {
// NOTE(Feoramund): This is the allocator that will be used by threads to // NOTE(Feoramund): This is the allocator that will be used by threads to
// persist log messages past their lifetimes. It has its own variable name // persist log messages past their lifetimes. It has its own variable name
// in the event it needs to be changed from `safe_heap_allocator` without // in the event it needs to be changed from `context.allocator` without
// digging through the source to divine everywhere it is used for that. // digging through the source to divine everywhere it is used for that.
shared_log_allocator := safe_heap_allocator shared_log_allocator := context.allocator
context.allocator = safe_heap_allocator
context.logger = { context.logger = {
procedure = runner_logger_proc, procedure = runner_logger_proc,