ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-05 15:18:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3353 from laytan/fix-incomplete-types-resize-segfault

Browse Source 
fix a segfault when incomplete types array resizes while processing
This commit is contained in:
gingerBill
2024-03-29 22:13:01 +00:00
committed by GitHub
parent 8899f42478 915f63b3f9
commit db95ed7cdd
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/llvm_backend_debug.cpp
+3 -1
View File
@@ -652,7 +652,9 @@ gb_internal void lb_debug_complete_types(lbModule *m) {
for_array(debug_incomplete_type_index, m->debug_incomplete_types) { for_array(debug_incomplete_type_index, m->debug_incomplete_types) {
TEMPORARY_ALLOCATOR_GUARD(); TEMPORARY_ALLOCATOR_GUARD();
auto const &idt = m->debug_incomplete_types[debug_incomplete_type_index]; // NOTE(laytan): don't make this a pointer, the array could resize while in this iteration
// and cause a use-after-free at the end.
auto const idt = m->debug_incomplete_types[debug_incomplete_type_index];
GB_ASSERT(idt.type != nullptr); GB_ASSERT(idt.type != nullptr);
GB_ASSERT(idt.metadata != nullptr); GB_ASSERT(idt.metadata != nullptr);