ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-03 05:08:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve error message for check_is_expressible (Cannot convert X to Y from Z)

Browse Source
This commit is contained in:
gingerBill
2022-09-22 00:34:36 +01:00
parent 3aea9a7c20
commit dade5b5ef2
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/check_expr.cpp
+6 -3
View File
@@ -2053,15 +2053,18 @@ bool check_is_expressible(CheckerContext *ctx, Operand *o, Type *type) {
o->mode = Addressing_Invalid; o->mode = Addressing_Invalid;
); );
gbString s = exact_value_to_string(o->value);
defer (gb_string_free(s));
if (is_type_numeric(o->type) && is_type_numeric(type)) { if (is_type_numeric(o->type) && is_type_numeric(type)) {
if (!is_type_integer(o->type) && is_type_integer(type)) { if (!is_type_integer(o->type) && is_type_integer(type)) {
error(o->expr, "'%s' truncated to '%s'", a, b); error(o->expr, "'%s' truncated to '%s', got %s", a, b, s);
} else { } else {
error(o->expr, "Cannot convert numeric value '%s' to '%s' from '%s", a, b, c); error(o->expr, "Cannot convert numeric value '%s' to '%s' from '%s', got %s", a, b, c, s);
check_assignment_error_suggestion(ctx, o, type); check_assignment_error_suggestion(ctx, o, type);
} }
} else { } else {
error(o->expr, "Cannot convert '%s' to '%s' from '%s", a, b, c); error(o->expr, "Cannot convert '%s' to '%s' from '%s', got %s", a, b, c, s);
check_assignment_error_suggestion(ctx, o, type); check_assignment_error_suggestion(ctx, o, type);
} }
return false; return false;