ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-05 07:08:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug unmarshalling JSON with assertions disabled

Browse Source 
When asserts are disabled, code within the assert isn't run. Having
expect_token within an assert means that the state of the Parser is
mutated when asserts are run, but not when they aren't.

There's already a wrapper procedure for this pattern, which I have
reused here.
This commit is contained in:
William Roe
2022-07-28 13:56:14 +01:00
parent 4af8a64580
commit d913155972
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/encoding/json/unmarshal.odin
+2 -2
View File
@@ -325,7 +325,7 @@ unmarshal_object :: proc(p: ^Parser, v: any, end_token: Token_Kind) -> (err: Unm
UNSUPPORTED_TYPE := Unsupported_Type_Error{v.id, p.curr_token} UNSUPPORTED_TYPE := Unsupported_Type_Error{v.id, p.curr_token}
if end_token == .Close_Brace { if end_token == .Close_Brace {
assert(expect_token(p, .Open_Brace) == nil) unmarshal_expect_token(p, .Open_Brace)
} }
v := v v := v
@@ -473,7 +473,7 @@ unmarshal_object :: proc(p: ^Parser, v: any, end_token: Token_Kind) -> (err: Unm
} }
if end_token == .Close_Brace { if end_token == .Close_Brace {
assert(expect_token(p, .Close_Brace) == nil) unmarshal_expect_token(p, .Close_Brace)
} }
return return
} }