ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-05 15:18:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

PNG: Fix leak if you don't ask for metadata.

Browse Source
This commit is contained in:
Jeroen van Rijn
2021-06-21 22:47:54 +02:00
parent 922b511a24
commit d5e2b387fa
2 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/image/png/helpers.odin
+2 -4
View File
@@ -34,10 +34,8 @@ destroy :: proc(img: ^Image) {
} }
bytes.buffer_destroy(&img.pixels); bytes.buffer_destroy(&img.pixels);
if img.metadata_ptr != nil && img.metadata_type == Info { // Clean up Info.
// Clean up Info. free(img.metadata_ptr);
free(img.metadata_ptr);
}
/* /*
We don't need to do anything for the individual chunks. We don't need to do anything for the individual chunks.
core/image/png/png.odin
+2 -4
View File
@@ -402,6 +402,8 @@ load_from_stream :: proc(stream: io.Stream, options := Options{}, allocator := c
} }
info := new(Info, context.allocator); info := new(Info, context.allocator);
img.metadata_ptr = info;
img.metadata_type = typeid_of(Info);
ctx := &compress.Context{ ctx := &compress.Context{
input = stream, input = stream,
@@ -663,10 +665,6 @@ load_from_stream :: proc(stream: io.Stream, options := Options{}, allocator := c
} }
} }
if .return_header in options || .return_metadata in options {
img.metadata_ptr = info;
img.metadata_type = typeid_of(Info);
}
if .do_not_decompress_image in options { if .do_not_decompress_image in options {
img.channels = final_image_channels; img.channels = final_image_channels;
return img, nil; return img, nil;