ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-05 07:08:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove goto in favour of multiple exits

Browse Source
This commit is contained in:
gingerBill
2021-09-08 11:58:01 +01:00
parent 30554f4758
commit d4f5ef046d
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/llvm_backend_expr.cpp
+4 -2
View File
@@ -71,7 +71,10 @@ lbValue lb_emit_logical_binary_expr(lbProcedure *p, TokenKind op, Ast *left, Ast
if (phi_type == nullptr) { if (phi_type == nullptr) {
phi = LLVMBuildPhi(p->builder, dst_type, ""); phi = LLVMBuildPhi(p->builder, dst_type, "");
LLVMAddIncoming(phi, incoming_values.data, incoming_blocks.data, cast(unsigned)incoming_values.count); LLVMAddIncoming(phi, incoming_values.data, incoming_blocks.data, cast(unsigned)incoming_values.count);
goto phi_end; lbValue res = {};
res.type = type;
res.value = phi;
return res;
} }
for_array(i, incoming_values) { for_array(i, incoming_values) {
@@ -102,7 +105,6 @@ lbValue lb_emit_logical_binary_expr(lbProcedure *p, TokenKind op, Ast *left, Ast
phi = LLVMBuildTruncOrBitCast(p->builder, phi, dst_type, ""); phi = LLVMBuildTruncOrBitCast(p->builder, phi, dst_type, "");
} }
phi_end:;
lbValue res = {}; lbValue res = {};
res.type = type; res.type = type;
res.value = phi; res.value = phi;