ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-04 22:58:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove double removal of extension when using the -out option.

Browse Source 
When specifying the out parameter, the extension was stripped twice.
If your path contains a ".", this caused issues.

e.g.
cd "C:\Repro\Path With a . In The Name\"
odin run repro.odin -keep-temp-files -out repro.exe

This would cause the files to end up as:
"C:\Repro\Path With a.exe", "C:\Repro\Path With a.ll", "C:\Repro\Path With a.bc" and "C:\Repro\Path With a.obj"

With this patch it works as expected, with or without a . in the file path.
This commit is contained in:
Jeroen van Rijn
2021-03-06 23:09:15 +01:00
parent 083cec6c88
commit cefde23232
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main.cpp
-6
View File
@@ -875,12 +875,6 @@ bool parse_build_flags(Array<String> args) {
String path = value.value_string; String path = value.value_string;
path = string_trim_whitespace(path); path = string_trim_whitespace(path);
if (is_build_flag_path_valid(path)) { if (is_build_flag_path_valid(path)) {
#if defined(GB_SYSTEM_WINDOWS)
String ext = path_extension(path);
if (ext == ".exe") {
path = substring(path, 0, string_extension_position(path));
}
#endif
build_context.out_filepath = path_to_full_path(heap_allocator(), path); build_context.out_filepath = path_to_full_path(heap_allocator(), path);
} else { } else {
gb_printf_err("Invalid -out path, got %.*s\n", LIT(path)); gb_printf_err("Invalid -out path, got %.*s\n", LIT(path));