ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-06 15:48:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add suggestions for indexing constant values with a variable index

Browse Source
This commit is contained in:
gingerBill
2020-01-18 12:09:26 +00:00
parent 23ff98dea0
commit cd43f4c94c
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/check_expr.cpp
+2
View File
@@ -8874,6 +8874,7 @@ ExprKind check_expr_base_internal(CheckerContext *c, Operand *o, Ast *node, Type
if (index < 0) { if (index < 0) {
gbString str = expr_to_string(o->expr); gbString str = expr_to_string(o->expr);
error(o->expr, "Cannot index a constant '%s'", str); error(o->expr, "Cannot index a constant '%s'", str);
error_line("\tSuggestion: store the constant into a variable in order to index it with a variable index\n");
gb_string_free(str); gb_string_free(str);
o->mode = Addressing_Invalid; o->mode = Addressing_Invalid;
o->expr = node; o->expr = node;
@@ -9009,6 +9010,7 @@ ExprKind check_expr_base_internal(CheckerContext *c, Operand *o, Ast *node, Type
if (!all_constant) { if (!all_constant) {
gbString str = expr_to_string(o->expr); gbString str = expr_to_string(o->expr);
error(o->expr, "Cannot slice '%s' with non-constant indices", str); error(o->expr, "Cannot slice '%s' with non-constant indices", str);
error_line("\tSuggestion: store the constant into a variable in order to index it with a variable index\n");
gb_string_free(str); gb_string_free(str);
o->mode = Addressing_Value; // NOTE(bill): Keep subsequent values going without erring o->mode = Addressing_Value; // NOTE(bill): Keep subsequent values going without erring
o->expr = node; o->expr = node;