ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-06 23:58:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix bitwise not for signed integers

Browse Source
This commit is contained in:
gingerBill
2018-06-15 23:01:12 +01:00
parent cd7e260f4e
commit ba776a3c9f
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/check_expr.cpp
+1 -1
View File
@@ -1465,7 +1465,7 @@ void check_unary_expr(CheckerContext *c, Operand *o, Token op, AstNode *node) {
return; return;
} }
o->value = exact_unary_operator_value(op.kind, o->value, precision); o->value = exact_unary_operator_value(op.kind, o->value, precision, is_type_unsigned(type));
if (is_type_typed(type)) { if (is_type_typed(type)) {
if (node != nullptr) { if (node != nullptr) {
src/exact_value.cpp
+4 -2
View File
@@ -353,7 +353,7 @@ ExactValue exact_value_make_imag(ExactValue v) {
} }
ExactValue exact_unary_operator_value(TokenKind op, ExactValue v, i32 precision) { ExactValue exact_unary_operator_value(TokenKind op, ExactValue v, i32 precision, bool is_unsigned) {
switch (op) { switch (op) {
case Token_Add: { case Token_Add: {
switch (v.kind) { switch (v.kind) {
@@ -404,7 +404,9 @@ ExactValue exact_unary_operator_value(TokenKind op, ExactValue v, i32 precision)
// NOTE(bill): unsigned integers will be negative and will need to be // NOTE(bill): unsigned integers will be negative and will need to be
// limited to the types precision // limited to the types precision
// IMPORTANT NOTE(bill): Max precision is 64 bits as that's how integers are stored // IMPORTANT NOTE(bill): Max precision is 64 bits as that's how integers are stored
i = i & unsigned_integer_maxs[precision/8]; if (is_unsigned) {
i = i & unsigned_integer_maxs[precision/8];
}
// if (0 < precision && precision < 64) { // if (0 < precision && precision < 64) {
// i = i & ~(-1ll << precision); // i = i & ~(-1ll << precision);
// } // }