ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-06 15:48:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Unify check_constant_parameter_value logic

Browse Source
This commit is contained in:
gingerBill
2023-04-27 10:58:17 +01:00
parent 023cc9ca54
commit acd8a4bc95
1 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/check_type.cpp
+15 -8
View File
@@ -378,6 +378,17 @@ gb_internal void add_polymorphic_record_entity(CheckerContext *ctx, Ast *node, T
rw_mutex_unlock(&ctx->info->gen_types_mutex); rw_mutex_unlock(&ctx->info->gen_types_mutex);
} }
bool check_constant_parameter_value(Type *type, Ast *expr) {
if (!is_type_constant_type(type)) {
gbString str = type_to_string(type);
defer (gb_string_free(str));
error(expr, "A parameter must be a valid constant type, got %s", str);
return true;
}
return false;
}
gb_internal Type *check_record_polymorphic_params(CheckerContext *ctx, Ast *polymorphic_params, gb_internal Type *check_record_polymorphic_params(CheckerContext *ctx, Ast *polymorphic_params,
bool *is_polymorphic_, bool *is_polymorphic_,
Ast *node, Array<Operand> *poly_operands) { Ast *node, Array<Operand> *poly_operands) {
@@ -477,10 +488,8 @@ gb_internal Type *check_record_polymorphic_params(CheckerContext *ctx, Ast *poly
type = t_invalid; type = t_invalid;
} }
if (!is_type_param && !is_type_constant_type(type)) { if (!is_type_param && check_constant_parameter_value(type, params[i])) {
gbString str = type_to_string(type); // failed
error(params[i], "A parameter must be a valid constant type, got %s", str);
gb_string_free(str);
} }
Scope *scope = ctx->scope; Scope *scope = ctx->scope;
@@ -1757,10 +1766,8 @@ gb_internal Type *check_get_params(CheckerContext *ctx, Scope *scope, Ast *_para
p->flags &= ~FieldFlag_by_ptr; p->flags &= ~FieldFlag_by_ptr;
} }
if (!is_type_constant_type(type) && !is_type_polymorphic(type)) { if (!is_type_polymorphic(type) && check_constant_parameter_value(type, params[i])) {
gbString str = type_to_string(type); // failed
error(params[i], "A parameter must be a valid constant type, got %s", str);
gb_string_free(str);
} }
param = alloc_entity_const_param(scope, name->Ident.token, type, poly_const, is_type_polymorphic(type)); param = alloc_entity_const_param(scope, name->Ident.token, type, poly_const, is_type_polymorphic(type));