ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-06 15:48:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

os/os2: Properly update CWD on Linux when using _process_start()

Browse Source 
The `dir_fd` argument to `execveat()` is not for setting the current working
directory. It is used to resolve relative executable paths, hence explicit
`chdir/fchdir` call is required to set CWD.
This commit is contained in:
Roland Kovacs
2025-01-20 22:34:49 +01:00
parent 20fa9fbd61
commit ac30d36206
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/os/os2/process_linux.odin
+4
View File
@@ -547,6 +547,10 @@ _process_start :: proc(desc: Process_Desc) -> (process: Process, err: Error) {
if _, errno = linux.dup2(stderr_fd, STDERR); errno != .NONE { if _, errno = linux.dup2(stderr_fd, STDERR); errno != .NONE {
write_errno_to_parent_and_abort(child_pipe_fds[WRITE], errno) write_errno_to_parent_and_abort(child_pipe_fds[WRITE], errno)
} }
if dir_fd != linux.AT_FDCWD {
errno = linux.fchdir(dir_fd)
assert(errno == nil)
}
errno = linux.execveat(dir_fd, exe_path, &cargs[0], env) errno = linux.execveat(dir_fd, exe_path, &cargs[0], env)
assert(errno != nil) assert(errno != nil)