ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-06 07:38:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5194 from Feoramund/fix-5067

Browse Source 
Fix off-by-one error in `priority_queue.remove`
This commit is contained in:
Jeroen van Rijn
2025-05-21 16:21:14 +02:00
committed by GitHub
parent 96bbd944dc 1662ab10af
commit a2c0720fb0
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/container/priority_queue/priority_queue.odin
+4 -6
View File
@@ -133,12 +133,10 @@ pop_safe :: proc(pq: ^$Q/Priority_Queue($T), loc := #caller_location) -> (value:
remove :: proc(pq: ^$Q/Priority_Queue($T), i: int) -> (value: T, ok: bool) { remove :: proc(pq: ^$Q/Priority_Queue($T), i: int) -> (value: T, ok: bool) {
n := builtin.len(pq.queue) n := builtin.len(pq.queue)
if 0 <= i && i < n { if 0 <= i && i < n {
if n != i { pq.swap(pq.queue[:], i, n-1)
pq.swap(pq.queue[:], i, n) _shift_down(pq, i, n-1)
_shift_down(pq, i, n) _shift_up(pq, i)
_shift_up(pq, i) value, ok = builtin.pop(&pq.queue), true
}
value, ok = builtin.pop_safe(&pq.queue)
} }
return return
} }