ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-06 15:48:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add better error messages with suggestions for using context as an identifier

Browse Source
This commit is contained in:
gingerBill
2024-04-04 17:01:31 +01:00
parent 2375ac22a7
commit 83e2f5ff74
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/parser.cpp
+14
View File
@@ -1482,7 +1482,16 @@ gb_internal Token expect_token(AstFile *f, TokenKind kind) {
if (prev.kind != kind) { if (prev.kind != kind) {
String c = token_strings[kind]; String c = token_strings[kind];
String p = token_to_string(prev); String p = token_to_string(prev);
begin_error_block();
syntax_error(f->curr_token, "Expected '%.*s', got '%.*s'", LIT(c), LIT(p)); syntax_error(f->curr_token, "Expected '%.*s', got '%.*s'", LIT(c), LIT(p));
if (kind == Token_Ident) switch (prev.kind) {
case Token_context:
error_line("\tSuggestion: 'context' is a reserved keyword, would 'ctx' suffice?\n");
break;
}
end_error_block();
if (prev.kind == Token_EOF) { if (prev.kind == Token_EOF) {
exit_with_errors(); exit_with_errors();
} }
@@ -4055,7 +4064,12 @@ gb_internal Array<Ast *> convert_to_ident_list(AstFile *f, Array<AstAndFlags> li
case Ast_BadExpr: case Ast_BadExpr:
break; break;
case Ast_Implicit: case Ast_Implicit:
begin_error_block();
syntax_error(ident, "Expected an identifier, '%.*s' which is a keyword", LIT(ident->Implicit.string)); syntax_error(ident, "Expected an identifier, '%.*s' which is a keyword", LIT(ident->Implicit.string));
if (ident->Implicit.kind == Token_context) {
error_line("\tSuggestion: Would 'ctx' suffice as an alternative name?\n");
}
end_error_block();
ident = ast_ident(f, blank_token); ident = ast_ident(f, blank_token);
break; break;