ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-06 07:38:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

checker: only error with -vet-cast when it is actually castable

Browse Source
This commit is contained in:
Laytan Laats
2024-11-21 19:18:17 +01:00
parent a88ac1d210
commit 83bf0c6ab8
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/check_expr.cpp
+4 -1
View File
@@ -3541,6 +3541,8 @@ gb_internal bool check_transmute(CheckerContext *c, Ast *node, Operand *o, Type
return false; return false;
} }
Operand src = *o;
Type *src_t = o->type; Type *src_t = o->type;
Type *dst_t = t; Type *dst_t = t;
Type *src_bt = base_type(src_t); Type *src_bt = base_type(src_t);
@@ -3629,7 +3631,8 @@ gb_internal bool check_transmute(CheckerContext *c, Ast *node, Operand *o, Type
// identical casts that cannot be foreseen or otherwise // identical casts that cannot be foreseen or otherwise
// forbidden, so just skip them. // forbidden, so just skip them.
if (forbid_identical && check_vet_flags(c) & VetFlag_Cast && if (forbid_identical && check_vet_flags(c) & VetFlag_Cast &&
(c->curr_proc_sig == nullptr || !is_type_polymorphic(c->curr_proc_sig))) { (c->curr_proc_sig == nullptr || !is_type_polymorphic(c->curr_proc_sig)) &&
check_is_castable_to(c, &src, dst_t)) {
if (are_types_identical(src_t, dst_t)) { if (are_types_identical(src_t, dst_t)) {
gbString oper_str = expr_to_string(o->expr); gbString oper_str = expr_to_string(o->expr);
gbString to_type = type_to_string(dst_t); gbString to_type = type_to_string(dst_t);