ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-05 23:28:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make linkage weak in certain places

Browse Source
This commit is contained in:
gingerBill
2024-07-15 12:30:32 +01:00
parent 549311fac9
commit 7d643bcae3
2 changed files with 49 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/llvm_backend.cpp
+9 -4
View File
@@ -144,11 +144,14 @@ gb_internal void lb_correct_entity_linkage(lbGenerator *gen) {
LLVMValueRef other_global = nullptr; LLVMValueRef other_global = nullptr;
if (ec.e->kind == Entity_Variable) { if (ec.e->kind == Entity_Variable) {
other_global = LLVMGetNamedGlobal(ec.other_module->mod, ec.cname); other_global = LLVMGetNamedGlobal(ec.other_module->mod, ec.cname);
if (other_global) {
LLVMSetLinkage(other_global, LLVMWeakAnyLinkage);
}
} else if (ec.e->kind == Entity_Procedure) { } else if (ec.e->kind == Entity_Procedure) {
other_global = LLVMGetNamedFunction(ec.other_module->mod, ec.cname); other_global = LLVMGetNamedFunction(ec.other_module->mod, ec.cname);
}
if (other_global) { if (other_global) {
LLVMSetLinkage(other_global, LLVMExternalLinkage); LLVMSetLinkage(other_global, LLVMWeakAnyLinkage);
}
} }
} }
} }
@@ -1437,7 +1440,9 @@ gb_internal bool lb_is_module_empty(lbModule *m) {
} }
for (auto g = LLVMGetFirstGlobal(m->mod); g != nullptr; g = LLVMGetNextGlobal(g)) { for (auto g = LLVMGetFirstGlobal(m->mod); g != nullptr; g = LLVMGetNextGlobal(g)) {
if (LLVMGetLinkage(g) == LLVMExternalLinkage) { LLVMLinkage linkage = LLVMGetLinkage(g);
if (linkage == LLVMExternalLinkage ||
linkage == LLVMWeakAnyLinkage) {
continue; continue;
} }
if (!LLVMIsExternallyInitialized(g)) { if (!LLVMIsExternallyInitialized(g)) {
@@ -3266,7 +3271,7 @@ gb_internal bool lb_generate_code(lbGenerator *gen) {
LLVMSetLinkage(g.value, LLVMDLLExportLinkage); LLVMSetLinkage(g.value, LLVMDLLExportLinkage);
LLVMSetDLLStorageClass(g.value, LLVMDLLExportStorageClass); LLVMSetDLLStorageClass(g.value, LLVMDLLExportStorageClass);
} else if (!is_foreign) { } else if (!is_foreign) {
LLVMSetLinkage(g.value, USE_SEPARATE_MODULES ? LLVMExternalLinkage : LLVMInternalLinkage); LLVMSetLinkage(g.value, USE_SEPARATE_MODULES ? LLVMWeakAnyLinkage : LLVMInternalLinkage);
} }
lb_set_linkage_from_entity_flags(m, g.value, e->flags); lb_set_linkage_from_entity_flags(m, g.value, e->flags);
src/llvm_backend_general.cpp
+6 -11
View File
@@ -3043,12 +3043,7 @@ gb_internal lbValue lb_find_value_from_entity(lbModule *m, Entity *e) {
return *found; return *found;
} }
lbValue g = {}; if (USE_SEPARATE_MODULES) {
String name = {};
if (!USE_SEPARATE_MODULES) {
goto failed;
}
lbModule *other_module = lb_module_of_entity(m->gen, e); lbModule *other_module = lb_module_of_entity(m->gen, e);
bool is_external = other_module != m; bool is_external = other_module != m;
@@ -3061,11 +3056,10 @@ gb_internal lbValue lb_find_value_from_entity(lbModule *m, Entity *e) {
is_external = other_module != m; is_external = other_module != m;
} }
if (!is_external) { if (is_external) {
goto failed; String name = lb_get_entity_name(other_module, e);
}
name = lb_get_entity_name(other_module, e);
lbValue g = {};
g.value = LLVMAddGlobal(m->mod, lb_type(m, e->type), alloc_cstring(permanent_allocator(), name)); g.value = LLVMAddGlobal(m->mod, lb_type(m, e->type), alloc_cstring(permanent_allocator(), name));
g.type = alloc_type_pointer(e->type); g.type = alloc_type_pointer(e->type);
lb_add_entity(m, e, g); lb_add_entity(m, e, g);
@@ -3096,8 +3090,9 @@ gb_internal lbValue lb_find_value_from_entity(lbModule *m, Entity *e) {
return g; return g;
}
}
failed:;
GB_PANIC("\n\tError in: %s, missing value '%.*s' in module %s\n", GB_PANIC("\n\tError in: %s, missing value '%.*s' in module %s\n",
token_pos_to_string(e->token.pos), LIT(e->token.string), m->module_name); token_pos_to_string(e->token.pos), LIT(e->token.string), m->module_name);
return {}; return {};