ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-05 07:08:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Forbid $T= parameter from crashing compiler

Browse Source 
Fixes #3883
This commit is contained in:
Feoramund
2024-07-06 15:32:17 -04:00
parent 88c9512d5f
commit 77d64a5461
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/check_expr.cpp
+11 -1
View File
@@ -7185,6 +7185,8 @@ gb_internal CallArgumentError check_polymorphic_record_type(CheckerContext *c, O
Array<Operand> operands = {}; Array<Operand> operands = {};
defer (array_free(&operands)); defer (array_free(&operands));
CallArgumentError err = CallArgumentError_None;
bool named_fields = false; bool named_fields = false;
{ {
// NOTE(bill, 2019-10-26): Allow a cycle in the parameters but not in the fields themselves // NOTE(bill, 2019-10-26): Allow a cycle in the parameters but not in the fields themselves
@@ -7202,6 +7204,11 @@ gb_internal CallArgumentError check_polymorphic_record_type(CheckerContext *c, O
Ast *arg = ce->args[i]; Ast *arg = ce->args[i];
ast_node(fv, FieldValue, arg); ast_node(fv, FieldValue, arg);
if (fv->value == nullptr) {
error(fv->eq, "Expected a value");
err = CallArgumentError_InvalidFieldValue;
continue;
}
if (fv->field->kind == Ast_Ident) { if (fv->field->kind == Ast_Ident) {
String name = fv->field->Ident.token.string; String name = fv->field->Ident.token.string;
isize index = lookup_polymorphic_record_parameter(original_type, name); isize index = lookup_polymorphic_record_parameter(original_type, name);
@@ -7240,7 +7247,10 @@ gb_internal CallArgumentError check_polymorphic_record_type(CheckerContext *c, O
} }
CallArgumentError err = CallArgumentError_None; if (err != 0) {
operand->mode = Addressing_Invalid;
return err;
}
TypeTuple *tuple = get_record_polymorphic_params(original_type); TypeTuple *tuple = get_record_polymorphic_params(original_type);
isize param_count = tuple->variables.count; isize param_count = tuple->variables.count;