ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-06 15:48:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Minor code clean up

Browse Source
This commit is contained in:
gingerBill
2025-02-18 13:24:08 +00:00
parent d69eb57cfa
commit 721bcf2249
1 changed files with 15 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/checker.cpp
+9 -41
View File
@@ -6741,11 +6741,17 @@ gb_internal void check_parsed_files(Checker *c) {
for_array(i, c->info.type_info_types) { for_array(i, c->info.type_info_types) {
auto const &tt = c->info.type_info_types[i]; auto const &tt = c->info.type_info_types[i];
bool exists = map_set_if_not_previously_exists(&c->info.minimum_dependency_type_info_index_map, cast(uintptr)tt.hash, i); bool exists = map_set_if_not_previously_exists(&c->info.minimum_dependency_type_info_index_map, cast(uintptr)tt.hash, i);
if (exists) { if (!exists) {
continue
}
for (auto const &entry : c->info.minimum_dependency_type_info_index_map) { for (auto const &entry : c->info.minimum_dependency_type_info_index_map) {
if (entry.key == cast(uintptr)tt.hash) { if (entry.key != cast(uintptr)tt.hash) {
continue;
}
auto const &other = c->info.type_info_types[entry.value]; auto const &other = c->info.type_info_types[entry.value];
if (!are_types_identical_unique_tuples(tt.type, other.type)) { if (are_types_identical_unique_tuples(tt.type, other.type)) {
continue;
}
gbString t = temp_canonical_string(tt.type); gbString t = temp_canonical_string(tt.type);
gbString o = temp_canonical_string(other.type); gbString o = temp_canonical_string(other.type);
GB_PANIC("%s (%s) %llu vs %s (%s) %llu", GB_PANIC("%s (%s) %llu vs %s (%s) %llu",
@@ -6753,48 +6759,10 @@ gb_internal void check_parsed_files(Checker *c) {
type_to_string(other.type, false), o, cast(unsigned long long)other.hash); type_to_string(other.type, false), o, cast(unsigned long long)other.hash);
} }
} }
}
}
}
GB_ASSERT(c->info.minimum_dependency_type_info_index_map.count <= c->info.type_info_types.count); GB_ASSERT(c->info.minimum_dependency_type_info_index_map.count <= c->info.type_info_types.count);
} }
// TIME_SECTION("check for type hash collisions");
// {
// PtrSet<uintptr> found = {};
// ptr_set_init(&found, c->info.type_info_types.count);
// defer (ptr_set_destroy(&found));
// for (auto const &tt : c->info.type_info_types) {
// if (ptr_set_update(&found, cast(uintptr)tt.hash)) {
// Type *other_type = nullptr;
// for (auto const &other : c->info.type_info_types) {
// if (&tt == &other) {
// continue;
// }
// if (cast(uintptr)other.hash == cast(uintptr)tt.hash &&
// !are_types_identical(tt.type, other.type)) {
// other_type = other.type;
// break;
// }
// }
// if (other_type != nullptr) {
// String ts = type_to_canonical_string(temporary_allocator(), tt.type);
// String os = type_to_canonical_string(temporary_allocator(), other_type);
// if (ts != os) {
// compiler_error("%s found type hash collision with %s (hash = %llu)\n"
// "%s vs %s\n",
// type_to_string(tt.type), type_to_string(other_type), cast(unsigned long long)tt.hash,
// temp_canonical_string(tt.type),
// temp_canonical_string(other_type)
// );
// }
// }
// }
// }
// }
TIME_SECTION("sort init and fini procedures"); TIME_SECTION("sort init and fini procedures");
check_sort_init_and_fini_procedures(c); check_sort_init_and_fini_procedures(c);